RabbitLabs/vylbot-app
RabbitLabs/vylbot-app
5
0
Fork 0
Code Issues 83 Pull requests Projects 1 Releases 23 Packages Wiki Activity Actions

Split up moon counter from the database #489

Merged
Vylpes merged 20 commits from feature/300-moon-set into develop 2025-02-03 17:42:11 +00:00
Conversation 1 Commits 20 Files changed 22 +1218 -21
Vylpes commented 2024-10-29 10:52:14 +00:00
Owner
Copy link

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

  • Create a separate moon counter to track how many moons a user has
  • This is so we can start a user at a specific counter
  • Added to the list command a counter to specify how many moons aren't being tracked with the bot

#300

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify the changes. Provide instructions so we can reproduce. Please also list any relevant details to your test configuration.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that provide my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
# Description Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. - Create a separate moon counter to track how many moons a user has - This is so we can start a user at a specific counter - Added to the list command a counter to specify how many moons aren't being tracked with the bot #300 ## Type of change Please delete options that are not relevant. - [x] New feature (non-breaking change which adds functionality) # How Has This Been Tested? Please describe the tests that you ran to verify the changes. Provide instructions so we can reproduce. Please also list any relevant details to your test configuration. # Checklist - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that provide my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules
Vylpes added 9 commits 2024-10-29 10:52:14 +00:00
WIP: Add UserSetting entity
All checks were successful
Test / build (push) Successful in 6s
Details
789d5d6410
Make moon count come from user setting table
All checks were successful
Test / build (push) Successful in 6s
Details
476ff7cfc4
WIP: Start of moonset command
All checks were successful
Test / build (push) Successful in 6s
Details
4d20d9e608
Add untracked counter
All checks were successful
Test / build (push) Successful in 6s
Details
866beb0e04
Vylpes requested review from VylpesTester 2024-10-29 10:52:19 +00:00
Vylpes added the
type
story
 label 2024-10-29 10:52:26 +00:00
VylpesTester was assigned by Vylpes 2024-10-29 10:52:35 +00:00
Vylpes changed title from Split up moon counter from the database to WIP: Split up moon counter from the database 2024-10-29 10:53:22 +00:00
Vylpes added 1 commit 2024-10-30 09:35:40 +00:00
WIP: Planning list.test.ts
All checks were successful
Test / build (push) Successful in 9s
Details
974e298214
Vylpes added 1 commit 2024-10-31 16:56:39 +00:00
WIP: Planning more tests
All checks were successful
Test / build (push) Successful in 10s
Details
43751e5b02
Vylpes added 3 commits 2024-11-01 17:06:04 +00:00
WIP: Create moons list command tests
All checks were successful
Test / build (push) Successful in 11s
Details
952e7901ba
Vylpes added 1 commit 2024-11-04 18:06:56 +00:00
WIP: Start creating buttonEvent moons list tests
All checks were successful
Test / build (push) Successful in 11s
Details
554c274a7f
Vylpes added 1 commit 2024-11-07 19:38:20 +00:00
WIP: Create add moon command tests
All checks were successful
Test / build (push) Successful in 18s
Details
056783bc44
Vylpes added 2 commits 2024-12-11 18:42:02 +00:00
Create add moon command tests
All checks were successful
Test / build (push) Successful in 24s
Details
e557540d70
Vylpes added 1 commit 2024-12-14 18:04:08 +00:00
Add tests
All checks were successful
Test / build (push) Successful in 24s
Details
1f5965ae79
Vylpes changed title from WIP: Split up moon counter from the database to Split up moon counter from the database 2024-12-14 18:04:51 +00:00
VylpesTester requested changes 2025-01-25 16:56:51 +00:00
Dismissed
VylpesTester left a comment
Member
Copy link
  • Merge in develop branch
  • Add moonset command
- Merge in `develop` branch - Add moonset command
Vylpes added 1 commit 2025-01-27 18:48:13 +00:00
Merge branch 'develop' into feature/300-moon-set
All checks were successful
Test / build (push) Successful in 25s
Details
238d8d190d
Vylpes commented 2025-01-27 18:48:53 +00:00
Author
Owner
Copy link
  • Merge in develop branch
  • Add moonset command

Have merged in develop, can't do moonset but will add the ability for moderators to remove moons at a time

> - Merge in `develop` branch > - Add moonset command Have merged in develop, can't do moonset but will add the ability for moderators to remove moons at a time
Vylpes requested review from VylpesTester 2025-01-27 18:49:09 +00:00
VylpesTester approved these changes 2025-02-03 17:42:03 +00:00
Vylpes merged commit 93ef8a8ae7 into develop 2025-02-03 17:42:11 +00:00
Vylpes deleted branch feature/300-moon-set 2025-02-03 17:42:12 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
VylpesTester
Labels
Clear labels   
blocked

   
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
needs criteria

   
needs estimate

   
needs testing

   
question

Further information is requested

  
type
admin

  
type
bug
Something isn't working

  
type
change

  
type
defect
A task that has fallen out of testing

  
type
dependencies
Pull requests that update a dependency file

  
type
documentation
Improvements or additions to documentation

  
type
epic

  
type
incident

  
type
investigation

  
type
spike

  
type
story

  
type
subtask

  
wontfix

This will not be worked on

  
blocked

   
duplicate

   
needs criteria

   
needs designs

   
needs estimate

   
needs testing

   
question
  
type
admin

  
type
alert

  
type
bug

  
type
defect

  
type
dependencies

  
type
design

  
type
documentation

  
type
epic

  
type
incident

  
type
investigation

  
type
spike

  
type
story

  
won't fix
No labels
blocked
duplicate
enhancement
good first issue
help wanted
invalid
needs criteria
needs estimate
needs testing
question
type
admin
type
bug
type
change
type
defect
type
dependencies
type
documentation
type
epic
type
incident
type
investigation
type
spike
type
story
type
subtask
wontfix
blocked
duplicate
needs criteria
needs designs
needs estimate
needs testing
question
type
admin
type
alert
type
bug
type
defect
type
dependencies
type
design
type
documentation
type
epic
type
incident
type
investigation
type
spike
type
story
won't fix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
VylpesTester
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: RabbitLabs/vylbot-app#489
No description provided.
Delete branch "feature/300-moon-set"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?