External/card-drop

Watch

Fork 0

Upgrade eslint to v10 #571

Open

Vylpes wants to merge 1 commit from feature/557-upgrade-eslint into release/0.11.0

Vylpes commented

2026-10-30 14:54:16 +00:00

Owner

#557

Vylpes added 1 commit

2026-10-30 14:54:17 +00:00

Upgrade eslint to v10

Test / build (push) Successful in 1m19s

Details

afb26f771f

Vylpes

2026-10-30 14:54:20 +00:00

added the
type
dependencies
label
requested review from Smithy-bot

Vylpes added this to the 0.11.0 milestone

2026-10-30 14:54:30 +00:00

Vylpes removed this from the 0.11.0 milestone

2026-10-30 14:54:31 +00:00

Smithy-bot was assigned by Vylpes

2026-10-30 14:54:35 +00:00

Smithy-bot requested changes

2026-10-31 11:02:37 +00:00

Smithy-bot left a comment

Request changes — eslint v10 upgrade looks fine, but the autofix in GetCardsHelper.ts regresses legendarychanceup.

legendaryChance was made const and the branch for hasLegendaryEffect no longer applies legendaryChance = boostedChance (nor reduces legendary when other effects fire). Threshold math still uses the base legendary weight, so the legendary slice is never doubled even though bronze/silver/gold/manga are reduced. Please restore boosted legendary weight in the cumulative thresholds (same pattern as gold/manga boosts) without reintroducing lint violations.

**Request changes** — eslint v10 upgrade looks fine, but the autofix in `GetCardsHelper.ts` regresses **legendarychanceup**. `legendaryChance` was made `const` and the branch for `hasLegendaryEffect` no longer applies `legendaryChance = boostedChance` (nor reduces legendary when other effects fire). Threshold math still uses the base legendary weight, so the legendary slice is never doubled even though bronze/silver/gold/manga are reduced. Please restore boosted legendary weight in the cumulative thresholds (same pattern as gold/manga boosts) without reintroducing lint violations.

Test / build (push) Successful in 1m19s

Details

This pull request can be merged automatically.

This branch is out-of-date with the base branch

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin feature/557-upgrade-eslint:feature/557-upgrade-eslint

git switch feature/557-upgrade-eslint

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch release/0.11.0

git merge --no-ff feature/557-upgrade-eslint

git switch feature/557-upgrade-eslint

git rebase release/0.11.0

git switch release/0.11.0

git merge --ff-only feature/557-upgrade-eslint

git switch feature/557-upgrade-eslint

git rebase release/0.11.0

git switch release/0.11.0

git merge --no-ff feature/557-upgrade-eslint

git switch release/0.11.0

git merge --squash feature/557-upgrade-eslint

git switch release/0.11.0

git merge --ff-only feature/557-upgrade-eslint

git switch release/0.11.0

git merge feature/557-upgrade-eslint

git push origin release/0.11.0

No reviewers

No milestone

No project

No assignees

2 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

External/card-drop!571

No description provided.

Rows
Columns