External/card-drop
Watch
5
0
Fork
You've already forked card-drop
 0
Code Issues 57 Pull requests 1 Projects 1 Releases 37 Packages Wiki Activity Actions

Add unclaimed filter to series list command #569

Merged
Vylpes merged 2 commits from feature/426-series-list-unclaimed-filter into release/0.11.0 2026-10-31 11:53:07 +00:00
Conversation 1 Commits 2 Files changed 7 +263 -26
Vylpes commented 2026-10-30 14:35:28 +00:00
Owner
Copy link

#426

#426
Add unclaimed filter to series list command
Some checks failed
Test / build (push) Failing after 1m21s
Details
f19fa8e2b5
Fix linter
All checks were successful
Test / build (push) Successful in 1m20s
Details
06e6c135e4
Vylpes changed title from WIP: Add unclaimed filter to series list command to Add unclaimed filter to series list command 2026-10-30 14:40:41 +00:00
Vylpes 2026-10-30 14:40:44 +00:00
Smithy-bot approved these changes 2026-10-31 11:02:38 +00:00
Smithy-bot left a comment
Copy link

Approved for #426.

The unclaimed filter is wired consistently through the slash filter option, button custom IDs (flag + returnPage), and SeriesHelper.GenerateSeriesListPage. Claim detection correctly ignores zero-quantity inventory rows, pagination runs on the filtered set, and empty states return clear messages. Tests cover slash/button flows, pagination, and edge cases.

**Approved** for #426. The unclaimed filter is wired consistently through the slash `filter` option, button custom IDs (`flag` + `returnPage`), and `SeriesHelper.GenerateSeriesListPage`. Claim detection correctly ignores zero-quantity inventory rows, pagination runs on the filtered set, and empty states return clear messages. Tests cover slash/button flows, pagination, and edge cases.
Vylpes merged commit ab0744ec43 into release/0.11.0 2026-10-31 11:53:07 +00:00
Vylpes deleted branch feature/426-series-list-unclaimed-filter 2026-10-31 11:53:07 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Smithy-bot
Labels
Clear labels
  
blocked

   
duplicate
This issue or pull request already exists

  
high priority
  
needs
approval

  
needs
criteria

  
needs
estimate

  
needs
tests

  
question
More information is needed

  
step
doing

  
step
review

  
step
testing

  
step
todo

  
step
uat

  
type
admin

  
type
alert

  
type
bug

  
type
change

  
type
defect

  
type
dependencies

  
type
development

  
type/documentation
  
type
epic

  
type
idea

  
type
incident

  
type
investigation

  
type
spike

  
type
story

  
type
tests

  
wontfix
This won't be fixed

No labels
blocked
duplicate
high priority
needs
approval
needs
criteria
needs
estimate
needs
tests
question
step
doing
step
review
step
testing
step
todo
step
uat
type
admin
type
alert
type
bug
type
change
type
defect
type
dependencies
type
development
type/documentation
type
epic
type
idea
type
incident
type
investigation
type
spike
type
story
type
tests
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
Smithy-bot
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
External/card-drop!569
No description provided.