Series list command should have an "unclaimed" filter #426

Open
opened 2025-03-29 14:38:51 +00:00 by Vylpes · 1 comment
Owner

Epic:
Story Points: 3


Add an "unclaimed" filter to the existing series list command so users can list only series that currently have unclaimed cards. Additionally, add an "Unclaimed" button to the existing series list pagination UI (alongside Previous / Next) that toggles the filter on and shows only unclaimed series; include a Back (or Clear) button to revert to the previous unfiltered list/pagination.

This will let users quickly find active drops or card series that still have cards available to claim and inspect what they're missing.

Background / context

  • The /series list (or prefix) command currently lists series with pagination (prev/next). Users want an easy way to filter to series with currently unclaimed card instances.
  • UX suggestion: a UI button (next to previous/next) labeled "Unclaimed" triggers the filter; when active, the UI shows only unclaimed series and provides a "Back" button to undo the filter and return to the prior page state.

Acceptance Criteria

  • The series list command accepts a new filter option "unclaimed" (CLI or slash command):
    • Examples:
      • Slash: /series list filter:unclaimed
  • When the "unclaimed" filter is applied, results include only series that currently have at least one card instance matching "unclaimed" semantics (see Clarifying Questions).
  • The response format (embed fields, sorting, paging) is consistent with existing series list output.
  • The pagination UI gains a new interactive button labeled "Unclaimed" (or a toggle). When clicked:
    • It filters the displayed results to unclaimed series.
    • The UI shows a "Back" (or "Clear filter") button to return to the previous unfiltered paginated view and page index.
    • If there are no matching series, a friendly message is shown (same pattern as no-results today).
  • Query and command must be performant on large datasets (use EXISTS or indexed columns; avoid loading all rows into memory).
  • Unit and integration tests added for query and command behavior, including UI button actions.
  • Documentation (command help / README) updated to mention the new filter and the UI button behavior.

Subtasks

  • Implement filter backend logic
  • Implement button to toggle on the filter
  • Implement button to toggle off the filter
  • Add unit tests
  • Add documentation

Notes

  • Also at the bottom with the previous and next buttons, maybe a button that says “unclaimed” and it generates all the unclaimed ones so you can see what you’re missing? Then adding a back button to undo that “search filter” if you like
Epic: \ Story Points: 3 --- Add an "unclaimed" filter to the existing series list command so users can list only series that currently have unclaimed cards. Additionally, add an "Unclaimed" button to the existing series list pagination UI (alongside Previous / Next) that toggles the filter on and shows only unclaimed series; include a Back (or Clear) button to revert to the previous unfiltered list/pagination. This will let users quickly find active drops or card series that still have cards available to claim and inspect what they're missing. Background / context - The /series list (or prefix) command currently lists series with pagination (prev/next). Users want an easy way to filter to series with currently unclaimed card instances. - UX suggestion: a UI button (next to previous/next) labeled "Unclaimed" triggers the filter; when active, the UI shows only unclaimed series and provides a "Back" button to undo the filter and return to the prior page state. ## Acceptance Criteria - The series list command accepts a new filter option "unclaimed" (CLI or slash command): - Examples: - Slash: /series list filter:unclaimed - When the "unclaimed" filter is applied, results include only series that currently have at least one card instance matching "unclaimed" semantics (see Clarifying Questions). - The response format (embed fields, sorting, paging) is consistent with existing series list output. - The pagination UI gains a new interactive button labeled "Unclaimed" (or a toggle). When clicked: - It filters the displayed results to unclaimed series. - The UI shows a "Back" (or "Clear filter") button to return to the previous unfiltered paginated view and page index. - If there are no matching series, a friendly message is shown (same pattern as no-results today). - Query and command must be performant on large datasets (use EXISTS or indexed columns; avoid loading all rows into memory). - Unit and integration tests added for query and command behavior, including UI button actions. - Documentation (command help / README) updated to mention the new filter and the UI button behavior. ## Subtasks - [ ] Implement filter backend logic - [ ] Implement button to toggle on the filter - [ ] Implement button to toggle off the filter - [ ] Add unit tests - [ ] Add documentation ## Notes - Also at the bottom with the previous and next buttons, maybe a button that says “unclaimed” and it generates all the unclaimed ones so you can see what you’re missing? Then adding a back button to undo that “search filter” if you like
Vylpes added this to the 0.11.0 milestone 2026-09-16 18:29:21 +01:00
Vylpes added this to the 0.10 Sprint 4 project 2026-09-23 18:40:18 +01:00
Vylpes self-assigned this 2026-10-30 14:27:01 +00:00
Vylpes stopped working 2026-10-30 14:40:59 +00:00
13 minutes 16 seconds
Vylpes removed their assignment 2026-10-31 11:53:20 +00:00
Member

QA results — PASS

Tested on release/0.11.0 @ 2abbd87 (PR #569 merge ab0744e is an ancestor; tip also includes dotenv #570).

Verification

  • yarn install --frozen-lockfile PASS
  • yarn build (tsc) PASS
  • yarn lint PASS
  • yarn test PASS — 29 suites / 141 passed / 30 todo / 9 snapshots
  • Focused suites PASS — series command + button + helper 32/32

Acceptance criteria

AC Result
/series list filter:unclaimed slash option PASS — filter choice Unclaimed/unclaimed
Results only series with ≥1 unclaimed card PASS — helper filter + tests (incl. qty 0 inventory)
Embed/paging consistent with existing list PASS — same fields; title/footer show Unclaimed
Pagination UI Unclaimed toggle PASS — third button Unclaimed when unfiltered
Back restores prior page PASS — customId encodes returnPage
Friendly empty message PASS — "No series with unclaimed cards found."
Performant query PASS for this codebase — cards are already in-memory (CoreClient.Cards); filter is O(series×cards) over cached metadata + one inventory fetch
Unit/integration tests PASS — command, button, helper coverage
Docs PASS — slash option description + CHANGELOG entry for #426

Subtasks (from description)

Filter backend, Unclaimed/Back buttons, unit tests, and changelog/docs mention are covered by PR #569.

Left for human UAT

Discord smoke: /series list, /series list filter:unclaimed, Unclaimed → paginate → Back on a live guild.

Moving step/testing → step/uat and assigning @Vylpes.

## QA results — PASS Tested on `release/0.11.0` @ `2abbd87` (PR #569 merge `ab0744e` is an ancestor; tip also includes dotenv #570). ### Verification - `yarn install --frozen-lockfile` PASS - `yarn build` (`tsc`) PASS - `yarn lint` PASS - `yarn test` PASS — **29 suites / 141 passed / 30 todo / 9 snapshots** - Focused suites PASS — `series` command + button + helper **32/32** ### Acceptance criteria | AC | Result | | --- | --- | | `/series list filter:unclaimed` slash option | PASS — `filter` choice `Unclaimed`/`unclaimed` | | Results only series with ≥1 unclaimed card | PASS — helper filter + tests (incl. qty 0 inventory) | | Embed/paging consistent with existing list | PASS — same fields; title/footer show Unclaimed | | Pagination UI Unclaimed toggle | PASS — third button Unclaimed when unfiltered | | Back restores prior page | PASS — customId encodes `returnPage` | | Friendly empty message | PASS — "No series with unclaimed cards found." | | Performant query | PASS for this codebase — cards are already in-memory (`CoreClient.Cards`); filter is O(series×cards) over cached metadata + one inventory fetch | | Unit/integration tests | PASS — command, button, helper coverage | | Docs | PASS — slash option description + CHANGELOG entry for #426 | ### Subtasks (from description) Filter backend, Unclaimed/Back buttons, unit tests, and changelog/docs mention are covered by PR #569. ### Left for human UAT Discord smoke: `/series list`, `/series list filter:unclaimed`, Unclaimed → paginate → Back on a live guild. Moving `step/testing` → `step/uat` and assigning @Vylpes.
Smithy-bot stopped working 2026-11-03 11:03:35 +00:00
1 minute 29 seconds
Smithy-bot removed their assignment 2026-11-03 11:03:36 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
2 participants
Notifications
Total time spent: 14 minutes 45 seconds
Vylpes
13 minutes 16 seconds
Smithy-bot
1 minute 29 seconds
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
External/card-drop#426
No description provided.