External/card-drop
Watch
5
0
Fork
You've already forked card-drop
 0
Code Issues 39 Pull requests Projects 1 Releases 36 Packages Wiki Activity Actions

Fix comma-dangle in Inventory.test.ts (#517) #524

Merged
Vylpes merged 1 commit from cursor/517-inventory-test-comma-dangle into release/0.12.0 2026-09-11 14:02:05 +01:00
Conversation 1 Commits 1 Files changed 1 +8 -8
Smithy-bot commented 2026-09-11 12:05:18 +01:00
Member
Copy link

Follow-up for #517 after the QA lint failure on release/0.12.0.

Change

Strip trailing commas in tests/stringDropdowns/Inventory.test.ts so comma-dangle is clean now that #521 fixed the eslint files glob.

Verification (local on this branch)

  • yarn lint PASS
  • yarn build (tsc) PASS
  • yarn test PASS — 28 suites / 196 tests

No further eqeqeq work in this PR; that landed earlier via #519/#521. This only clears the residual comma-dangle failures exposed by the glob fix.

Follow-up for #517 after the QA lint failure on `release/0.12.0`. ## Change Strip trailing commas in `tests/stringDropdowns/Inventory.test.ts` so `comma-dangle` is clean now that #521 fixed the eslint `files` glob. ## Verification (local on this branch) - `yarn lint` PASS - `yarn build` (`tsc`) PASS - `yarn test` PASS — 28 suites / 196 tests No further `eqeqeq` work in this PR; that landed earlier via #519/#521. This only clears the residual `comma-dangle` failures exposed by the glob fix.
Smithy-bot added this to the 0.12.0 milestone 2026-09-11 12:05:18 +01:00
Fix comma-dangle in Inventory.test.ts (#517)
All checks were successful
Test / build (push) Successful in 1m42s
Details
22d603d21f
Vylpes approved these changes 2026-09-11 14:02:00 +01:00
Vylpes merged commit 42260e93ec into release/0.12.0 2026-09-11 14:02:05 +01:00
Vylpes deleted branch cursor/517-inventory-test-comma-dangle 2026-09-11 14:02:05 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Vylpes
Labels
Clear labels
  
blocked

   
duplicate
This issue or pull request already exists

  
needs
approval

  
needs
criteria

  
needs
estimate

  
needs
tests

  
question
More information is needed

  
step
doing

  
step
review

  
step
testing

  
step
todo

  
step
uat

  
type
admin

  
type
alert

  
type
bug

  
type
change

  
type
defect

  
type
dependencies

  
type
epic

  
type
idea

  
type
incident

  
type
investigation

  
type
spike

  
type
story

  
wontfix
This won't be fixed

No labels
blocked
duplicate
needs
approval
needs
criteria
needs
estimate
needs
tests
question
step
doing
step
review
step
testing
step
todo
step
uat
type
admin
type
alert
type
bug
type
change
type
defect
type
dependencies
type
epic
type
idea
type
incident
type
investigation
type
spike
type
story
wontfix
Milestone
Clear milestone
No items
No milestone
0.12.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
External/card-drop!524
No description provided.