External/card-drop
Watch
5
0
Fork
You've already forked card-drop
 0
Code Issues 60 Pull requests Projects 1 Releases 37 Packages Wiki Activity Actions

Fix eslint files glob not being correct #521

Merged
Vylpes merged 3 commits from feature/517-eslint-files into release/0.12.0 2026-09-08 14:29:30 +01:00
Conversation 2 Commits 3 Files changed 70 +273 -276
Vylpes commented 2026-09-07 11:45:11 +01:00
Owner
Copy link

#517

#517
Fix eslint files glob not being correct
All checks were successful
Test / build (push) Successful in 1m53s
Details
534ec602af
Vylpes changed title from Fix eslint files glob not being correct to WIP: Fix eslint files glob not being correct 2026-09-07 11:56:22 +01:00
Smithy-bot reviewed 2026-09-07 12:04:17 +01:00
Smithy-bot left a comment
Copy link

Comment — the eslint glob fix is correct, but this PR is not ready to merge yet.

What looks good

  • Changing files from "./src" / "./tests" to src/**/* / tests/**/* is the right fix; the old globs matched no files, leaving camelcase and other scoped rules inert.
  • The yarn lint:fix formatting pass is mechanical and consistent with existing style rules.

Why I'm not approving yet

  • PR is marked draft / WIP and currently has merge conflicts with release/0.12.0.
  • This branch does not include the #519 equality sweep or eqeqeq enablement — coordinate merge order with #519 so the glob fix lands on top of the completed strict-equality work.

Please mark ready and resolve conflicts, then re-request review.

**Comment** — the eslint glob fix is correct, but this PR is not ready to merge yet. **What looks good** - Changing `files` from `"./src"` / `"./tests"` to `src/**/*` / `tests/**/*` is the right fix; the old globs matched no files, leaving camelcase and other scoped rules inert. - The `yarn lint:fix` formatting pass is mechanical and consistent with existing style rules. **Why I'm not approving yet** - PR is marked **draft / WIP** and currently has merge conflicts with `release/0.12.0`. - This branch does not include the #519 equality sweep or `eqeqeq` enablement — coordinate merge order with #519 so the glob fix lands on top of the completed strict-equality work. Please mark ready and resolve conflicts, then re-request review.
Fix linter
All checks were successful
Test / build (push) Successful in 2m39s
Details
ac3dd25e26
Vylpes changed title from WIP: Fix eslint files glob not being correct to Fix eslint files glob not being correct 2026-09-07 12:15:37 +01:00
Smithy-bot approved these changes 2026-09-08 12:03:29 +01:00
Smithy-bot left a comment
Copy link

Approve — the ESLint glob fix is correct and this is ready to merge.

What changed

  • eslint.config.mjs now scopes rules to src/**/* and tests/**/* instead of ./src / ./tests, which previously matched no files and left camelcase, comma-dangle, and other style rules inert.
  • The remaining diff is a mechanical yarn lint:fix pass (mostly trailing-comma cleanup) triggered once those rules actually apply.

What looks good

  • The glob pattern is the right fix and aligns with the note in #517.
  • No behavioral logic changes beyond formatting.
  • PR is mergeable against current release/0.12.0.

Non-blocking

  • This addresses the inert-glob portion of #517 only; enabling eqeqeq and the full strict-equality sweep remain separate follow-up work.

No merge-blocking issues.

**Approve** — the ESLint glob fix is correct and this is ready to merge. **What changed** - `eslint.config.mjs` now scopes rules to `src/**/*` and `tests/**/*` instead of `./src` / `./tests`, which previously matched no files and left camelcase, comma-dangle, and other style rules inert. - The remaining diff is a mechanical `yarn lint:fix` pass (mostly trailing-comma cleanup) triggered once those rules actually apply. **What looks good** - The glob pattern is the right fix and aligns with the note in #517. - No behavioral logic changes beyond formatting. - PR is mergeable against current `release/0.12.0`. **Non-blocking** - This addresses the inert-glob portion of #517 only; enabling `eqeqeq` and the full strict-equality sweep remain separate follow-up work. No merge-blocking issues.
Vylpes merged commit d4bd48cdf5 into release/0.12.0 2026-09-08 14:29:30 +01:00
Vylpes deleted branch feature/517-eslint-files 2026-09-08 14:29:30 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Smithy-bot
VylpesTester
Labels
Clear labels   
question
More information is needed

  
blocked

   
duplicate
This issue or pull request already exists

  
needs
approval

  
needs
criteria

  
needs
estimate

  
needs
tests

  
question
More information is needed

  
step
doing

  
step
review

  
step
testing

  
step
todo

  
step
uat

  
type
admin

  
type
alert

  
type
bug

  
type
change

  
type
defect

  
type
dependencies

  
type
epic

  
type
idea

  
type
incident

  
type
investigation

  
type
spike

  
type
story

  
wontfix
This won't be fixed

No labels
question
blocked
duplicate
needs
approval
needs
criteria
needs
estimate
needs
tests
question
step
doing
step
review
step
testing
step
todo
step
uat
type
admin
type
alert
type
bug
type
change
type
defect
type
dependencies
type
epic
type
idea
type
incident
type
investigation
type
spike
type
story
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
Smithy-bot
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
External/card-drop!521
No description provided.