Finish strict equality sweep #519

Merged

Vylpes merged 1 commit from feature/517-finish-strict-equality-sweep into release/0.12.0

2026-09-07 12:07:22 +01:00

Vylpes commented

2026-09-07 11:42:36 +01:00

Owner

#517

Vylpes added the

type

change

label

2026-09-07 11:42:36 +01:00

Vylpes added 1 commit

2026-09-07 11:42:42 +01:00

Finish strict equality sweep

Test / build (push) Successful in 2m11s

Details

2e255b66e8

Smithy-bot was assigned by Vylpes

2026-09-07 11:44:43 +01:00

Vylpes requested review from Smithy-bot

2026-09-07 11:44:46 +01:00

Smithy-bot approved these changes

2026-09-07 12:04:17 +01:00

Smithy-bot left a comment

Approve — this completes the #517 strict-equality sweep and looks good to merge.

What looks good

Repo-wide ==/!= conversion across 41 src/ files; only intentional == null / != null checks remain (4 sites), which align with the eqeqeq { null: "ignore" } setting.
eqeqeq is enabled in a separate config block so enforcement works even while the ./src/./tests file globs are still broken (addressed separately in #521).
Bitmask environment checks ((environment & CoreClient.Environment) === …) and string/number comparisons are correctly tightened to ===.
tests/ already had no loose equality, so no test-file churn was needed.

Non-blocking

Merge #521 after this (or rebase it) so the scoped style rules start applying via the corrected src/**/* / tests/**/* globs.
Per #517, exercise /drop, /inventory, and /stats against real card data before release.

**Approve** — this completes the #517 strict-equality sweep and looks good to merge. **What looks good** - Repo-wide `==`/`!=` conversion across 41 `src/` files; only intentional `== null` / `!= null` checks remain (4 sites), which align with the `eqeqeq` `{ null: "ignore" }` setting. - `eqeqeq` is enabled in a separate config block so enforcement works even while the `./src`/`./tests` file globs are still broken (addressed separately in #521). - Bitmask environment checks (`(environment & CoreClient.Environment) === …`) and string/number comparisons are correctly tightened to `===`. - `tests/` already had no loose equality, so no test-file churn was needed. **Non-blocking** - Merge #521 after this (or rebase it) so the scoped style rules start applying via the corrected `src/**/*` / `tests/**/*` globs. - Per #517, exercise `/drop`, `/inventory`, and `/stats` against real card data before release.

Vylpes merged commit e4b46fe641 into release/0.12.0

2026-09-07 12:07:22 +01:00

Vylpes deleted branch feature/517-finish-strict-equality-sweep

2026-09-07 12:07:22 +01:00

Vylpes referenced this pull request from a commit

2026-09-07 12:07:22 +01:00

Merge pull request 'Finish strict equality sweep' (#519) from feature/517-finish-strict-equality-sweep into release/0.12.0