Update give command to allow currency to be given #220

Merged

Vylpes merged 2 commits from feature/206-give-currency into develop

2024-05-11 12:48:48 +01:00

Vylpes commented

2024-05-08 17:56:39 +01:00

Owner

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Update the give command to have the existing card functionality moved to a subcommand
Add a subcommand to the give command to allow currency to be given

#206

Type of change

Please delete options that are not relevant.

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify the changes. Provide instructions so we can reproduce. Please also list any relevant details to your test configuration.

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that provde my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules

# Description Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. - Update the give command to have the existing card functionality moved to a subcommand - Add a subcommand to the give command to allow currency to be given #206 ## Type of change Please delete options that are not relevant. - [x] New feature (non-breaking change which adds functionality) # How Has This Been Tested? Please describe the tests that you ran to verify the changes. Provide instructions so we can reproduce. Please also list any relevant details to your test configuration. # Checklist - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that provde my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules

Vylpes added 2 commits 2024-05-08 17:56:39 +01:00

Update give command to allow currency to be given

Test / build (push) Successful in 2m28s

Details

8527c0a870

Fix linter

Test / build (push) Successful in 9s

Details

b741ac154c

Vylpes requested review from VylpesTester 2024-05-08 17:56:46 +01:00

Vylpes added the

type

story

label 2024-05-08 17:56:49 +01:00

VylpesTester was assigned by Vylpes

2024-05-08 17:56:51 +01:00

Vylpes commented

2024-05-08 17:58:29 +01:00

Author

Owner

I had to switch the type argument in command.ts back to any, as typescript was getting too messy with the types, adding different options to the command builder was creating different types and was getting unmanageable. We will have to use any.

The ESLint rule has been disabled with a reason also

I had to switch the type argument in `command.ts` back to `any`, as typescript was getting too messy with the types, adding different options to the command builder was creating different types and was getting unmanageable. We will have to use `any`. The ESLint rule has been disabled with a reason also