RabbitLabs/vylbot-app
RabbitLabs/vylbot-app
Watch
5
0
Fork
You've already forked vylbot-app
 0
Code Issues 105 Pull requests 1 Projects 1 Releases 26 Packages Wiki Activity Actions

Rules parser to fail gracefully if there's an error #586

Merged
Vylpes merged 1 commit from feature/191-invalid-rules-json-error into release/3.4.0 2026-09-25 12:36:10 +01:00
Conversation 1 Commits 1 Files changed 2 +55 -1
Vylpes commented 2026-09-24 13:16:12 +01:00
Owner
Copy link

#191

#191
Rules parser to fail gracefully if there's an error
All checks were successful
Test / build (push) Successful in 1m9s
Details
43fe090eca
Smithy-bot approved these changes 2026-09-25 12:16:42 +01:00
Smithy-bot left a comment
Copy link

Approved — this cleanly addresses invalid rules JSON without changing happy-path behaviour.

The try/catch around JSON.parse returns an ephemeral, user-facing error and exits before embed generation, which matches the acceptance criteria. Tests cover the new failure mode alongside existing rules command cases.

No merge blockers from my side.

**Approved** — this cleanly addresses invalid rules JSON without changing happy-path behaviour. The `try/catch` around `JSON.parse` returns an ephemeral, user-facing error and exits before embed generation, which matches the acceptance criteria. Tests cover the new failure mode alongside existing rules command cases. No merge blockers from my side.
Vylpes merged commit 45fab10c60 into release/3.4.0 2026-09-25 12:36:10 +01:00
Vylpes deleted branch feature/191-invalid-rules-json-error 2026-09-25 12:36:10 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Smithy-bot
Labels
Clear labels
  
blocked

   
duplicate
  
needs
approval

  
needs
criteria

  
needs
estimate

  
needs
tests

  
question
  
step
doing

  
step
review

  
step
testing

  
step
todo

  
step
uat

  
type
admin

  
type
alert

  
type
bug

  
type
change

  
type
defect

  
type
dependencies

  
type
epic

  
type
idea

  
type
incident

  
type
investigation

  
type
spike

  
type
story

  
won't fix
No labels
blocked
duplicate
needs
approval
needs
criteria
needs
estimate
needs
tests
question
step
doing
step
review
step
testing
step
todo
step
uat
type
admin
type
alert
type
bug
type
change
type
defect
type
dependencies
type
epic
type
idea
type
incident
type
investigation
type
spike
type
story
won't fix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
Smithy-bot
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
RabbitLabs/vylbot-app!586
No description provided.