RabbitLabs/vylbot-app
RabbitLabs/vylbot-app
Watch
5
0
Fork
You've already forked vylbot-app
 0
Code Issues 106 Pull requests 1 Projects 1 Releases 26 Packages Wiki Activity Actions

Remove unused grid local in minesweeper test (#7) #581

Merged
Vylpes merged 2 commits from cursor/7-minesweeper-lint-unused-grid into release/3.5.0 2026-09-18 14:35:24 +01:00
Conversation 1 Commits 2 Files changed 4 +3 -6
Smithy-bot commented 2026-09-18 12:11:22 +01:00
Member
Copy link

Follow-up from QA on #7: yarn lint failed on an unused grid local in the adjacent-mines test (the test already spies Math.random and never reads that local).

Change

  • Remove the unused grid constant from tests/commands/minesweeper.test.ts

Verified locally

  • yarn lint PASS
  • yarn build PASS
  • yarn test PASS (3 suites / 29 tests)

Ticket: #7

Follow-up from QA on #7: `yarn lint` failed on an unused `grid` local in the adjacent-mines test (the test already spies `Math.random` and never reads that local). ## Change - Remove the unused `grid` constant from `tests/commands/minesweeper.test.ts` ## Verified locally - `yarn lint` PASS - `yarn build` PASS - `yarn test` PASS (3 suites / 29 tests) Ticket: #7
Smithy-bot added this to the 3.5.0 milestone 2026-09-18 12:11:22 +01:00
Remove unused grid local in minesweeper adjacent-mines test (#7)
All checks were successful
Test / build (push) Successful in 1m25s
Details
ce25d60a1e
Add lint to test script
All checks were successful
Test / build (push) Successful in 1m14s
Details
b2260d3a66
Vylpes approved these changes 2026-09-18 14:34:44 +01:00
Vylpes merged commit 31250de0b1 into release/3.5.0 2026-09-18 14:35:24 +01:00
Vylpes deleted branch cursor/7-minesweeper-lint-unused-grid 2026-09-18 14:35:24 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Vylpes
Labels
Clear labels
  
blocked

   
duplicate
  
needs
approval

  
needs
criteria

  
needs
estimate

  
needs
tests

  
question
  
step
doing

  
step
review

  
step
testing

  
step
todo

  
step
uat

  
type
admin

  
type
alert

  
type
bug

  
type
change

  
type
defect

  
type
dependencies

  
type
epic

  
type
idea

  
type
incident

  
type
investigation

  
type
spike

  
type
story

  
won't fix
No labels
blocked
duplicate
needs
approval
needs
criteria
needs
estimate
needs
tests
question
step
doing
step
review
step
testing
step
todo
step
uat
type
admin
type
alert
type
bug
type
change
type
defect
type
dependencies
type
epic
type
idea
type
incident
type
investigation
type
spike
type
story
won't fix
Milestone
Clear milestone
No items
No milestone
3.5.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
RabbitLabs/vylbot-app!581
No description provided.