Add RSS Feed Parser Service #579

Merged

Vylpes merged 2 commits from feature/530-rss-feed-parser into feature/epic-528-rss-feeds 2026-09-18 14:45:27 +01:00

Conversation 2 Commits 2 Files changed 4 +234

Vylpes commented 2026-09-17 18:16:06 +01:00

Owner

Copy link

#530

#530

Vylpes added the

type

story

label 2026-09-17 18:16:06 +01:00

Vylpes added 20 commits 2026-09-17 18:16:06 +01:00

Fix bunny button event not being registered 1bcf647221

Fix rules file not being found with an absolute path (#538) ... 123f4771a0

- Fix rules file not being found with an absolute path

#191

Reviewed-on: #538
Reviewed-by: VylpesTester <[email protected]>
Co-authored-by: Ethan Lane <[email protected]>
Co-committed-by: Ethan Lane <[email protected]>

Use rsync b0a5c661cc

Use rsync b568c95f1b

Use rsync 3f9548d0ab

Use rust 4ed095c834

Use rsync abc4437f1c

Use rsync 86435dad8d

Use rsync 3e065bb868

Rsync for prod 9d89eb2229

Update ssh cd path 9ffbb93461

Update stage deployment script to use rsync action 020b7684eb

Update prod deployment script to use rsync action 81fcceabb3

v3.3.1 16140c9cb0

Merge branch 'develop' into release/3.4.0 60f899d0f0

3.4 Dependency Updates edd03d708e

Fix audited packages 3f111ad083

Merge pull request 'Fix bunny button event not being registered' (#539) from feature/defect-321-event-not-found into release/3.4.0 ... b3ed2413f6

Reviewed-on: #539
Reviewed-by: VylpesTester <[email protected]>

Merge pull request 'feature/523-3-4-dependency-updates' (#577) from feature/523-3-4-dependency-updates into release/3.4.0 ... e2eda43ba7

Reviewed-on: #577
Reviewed-by: Smithy-bot <[email protected]>
Reviewed-by: VylpesTester <[email protected]>

Add rss feed parser bae452ca89

Vylpes added 1 commit 2026-09-17 18:17:03 +01:00

Merge branch 'feature/epic-528-rss-feeds' into feature/530-rss-feed-parser f7e1c0a6c8

Vylpes requested review from Smithy-bot 2026-09-18 14:36:20 +01:00

Smithy-bot was assigned by Vylpes 2026-09-18 14:36:23 +01:00

Smithy-bot approved these changes 2026-09-18 14:38:53 +01:00

Smithy-bot left a comment

Copy link

Approved — the RSS feed helper is well-structured and ready to merge into the epic branch.

What looks good:

• RssFeedHelper follows existing helper conventions (default-export class, PascalCase static methods like CacheHelper).
• FetchFeed validates http/https URLs before calling rss-parser, and wraps parse failures in a descriptive error.
• GetNewItems correctly assumes newest-first feed order, stops at lastGuid, and reverses to oldest-first for posting order.
• GetItemGuid sensibly falls back from guid to link.
• Returning an empty array when lastGuid is absent avoids flooding on first poll.
• Tests are thorough (mocked parser, invalid URL cases, guid/link identity, unknown lastGuid) and match the repo's GIVEN/EXPECT style.
• rss-parser dependency and lockfile are updated.

Non-blocking notes for follow-up stories:

• If lastGuid disappears from a feed (retention/rotation), all items are treated as new — callers may want a cap or reset strategy.
• Consider a fetch timeout when this is wired into a polling loop.

Nice work on #530.

**Approved** — the RSS feed helper is well-structured and ready to merge into the epic branch. **What looks good:** - `RssFeedHelper` follows existing helper conventions (default-export class, PascalCase static methods like `CacheHelper`). - `FetchFeed` validates http/https URLs before calling `rss-parser`, and wraps parse failures in a descriptive error. - `GetNewItems` correctly assumes newest-first feed order, stops at `lastGuid`, and reverses to oldest-first for posting order. - `GetItemGuid` sensibly falls back from `guid` to `link`. - Returning an empty array when `lastGuid` is absent avoids flooding on first poll. - Tests are thorough (mocked parser, invalid URL cases, guid/link identity, unknown `lastGuid`) and match the repo's GIVEN/EXPECT style. - `rss-parser` dependency and lockfile are updated. **Non-blocking notes for follow-up stories:** - If `lastGuid` disappears from a feed (retention/rotation), all items are treated as new — callers may want a cap or reset strategy. - Consider a fetch timeout when this is wired into a polling loop. Nice work on #530.

Vylpes merged commit c52f462494 into feature/epic-528-rss-feeds 2026-09-18 14:45:27 +01:00

Vylpes deleted branch feature/530-rss-feed-parser 2026-09-18 14:45:27 +01:00

Vylpes referenced this pull request from a commit 2026-09-18 14:45:28 +01:00

Merge pull request 'Add RSS Feed Parser Service' (#579) from feature/530-rss-feed-parser into feature/epic-528-rss-feeds

Smithy-bot referenced this pull request 2026-09-18 14:47:14 +01:00

RSS Feed Fetch Timeout #583

Smithy-bot referenced this pull request 2026-09-18 14:47:14 +01:00

RSS Feed lastGuid Rotation Handling #584

Smithy-bot commented 2026-09-18 14:47:26 +01:00

Member

Copy link

Follow-up stories from the review notes:

• #584 — RSS Feed lastGuid Rotation Handling (cap when lastGuid has rotated off the feed)
• #583 — RSS Feed Fetch Timeout (10s timeout on FetchFeed)

Both are on epic #528.

Follow-up stories from the review notes: - #584 — RSS Feed lastGuid Rotation Handling (cap when `lastGuid` has rotated off the feed) - #583 — RSS Feed Fetch Timeout (10s timeout on `FetchFeed`) Both are on epic #528.

Smithy-bot referenced this pull request 2026-09-25 12:11:03 +01:00

RSS Feed Parser Service #530

Sign in to join this conversation.

Reviewers

No reviewers

Smithy-bot

Labels

Clear labels

  

blocked

  

duplicate

  

needs

approval

  

needs

criteria

  

needs

estimate

  

needs

tests

  

question

  

step

doing

  

step

review

  

step

testing

  

step

todo

  

step

uat

  

type

admin

  

type

alert

  

type

bug

  

type

change

  

type

defect

  

type

dependencies

  

type

epic

  

type

idea

  

type

incident

  

type

investigation

  

type

spike

  

type

story

  

won't fix

No labels

blocked

duplicate

needs

approval

needs

criteria

needs

estimate

needs

tests

question

step

doing

step

review

step

testing

step

todo

step

uat

type

admin

type

alert

type

bug

type

change

type

defect

type

dependencies

type

epic

type

idea

type

incident

type

investigation

type

spike

type

story

won't fix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

Smithy-bot

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

RabbitLabs/vylbot-app!579

No description provided.