#214 Add ephemeral reply upon rules success #231

Vylpes · 2022-12-12T18:13:09Z

Vylpes commented

2022-12-12 18:13:09 +00:00

Added ephermeral reply to the rules command so the command doesn't respond with "application did not respond" even though it successfully ran

- Added ephermeral reply to the rules command so the command doesn't respond with "application did not respond" even though it successfully ran

Vylpes added 1 commit 2022-12-12 18:13:09 +00:00

Add ephemeral reply upon rules success c4b5d9671b

Vylpes requested review from VylpesTester 2022-12-12 18:13:14 +00:00

Vylpes added the

type

defect

label 2022-12-12 18:13:25 +00:00

Vylpes added this to the 3.1 milestone 2022-12-12 18:13:36 +00:00

Vylpes added this to the 3.1 Sprint 6 project 2022-12-12 18:13:40 +00:00

VylpesTester was assigned by Vylpes

2022-12-12 18:13:44 +00:00

VylpesTester requested changes 2022-12-16 21:17:19 +00:00

src/commands/rules.ts

					
				@ -34,3 +34,3 @@

				        const embeds: EmbedBuilder[] = [];

				        rules.forEach(rule => {

VylpesTester commented

2022-12-16 21:17:06 +00:00

Should we do anything if rules is empty? What about if the rules fail to be produced?

Vylpes marked this conversation as resolved

src/commands/rules.ts

					
				@ -55,7 +55,14 @@ export default class Rules extends Command {

				        if (!channel) {

VylpesTester commented

2022-12-16 21:16:12 +00:00

Might be worth adding a failed embed here, just in case and so it doesn't fail

Vylpes marked this conversation as resolved

VylpesTester added spent time 2022-12-16 21:17:56 +00:00

5 minutes

Vylpes changed title from ~~#214 Add ephemeral reply upon rules success~~ to #214 Add ephemeral reply upon rules success

2022-12-20 17:57:56 +00:00

Vylpes requested review from VylpesTester 2022-12-20 17:58:26 +00:00

Vylpes closed this pull request

2022-12-27 15:18:30 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

No reviewers

No milestone

No project

No assignees

2 participants

Notifications

Total time spent: 5 minutes

VylpesTester

5 minutes

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: RabbitLabs/vylbot-app#231

				`@ -55,7 +55,14 @@ export default class Rules extends Command {`
				`if (!channel) {`