RabbitLabs/vylbot-app
RabbitLabs/vylbot-app
Watch
5
0
Fork
You've already forked vylbot-app
 0
Code Issues 106 Pull requests 1 Projects 1 Releases 26 Packages Wiki Activity Actions

If the bot can't connect to the database it should not run #153

New issue
Open
opened 2022-05-09 18:21:01 +01:00 by Vylpes · 1 comment
Vylpes commented 2022-05-09 18:21:01 +01:00 (Migrated from github.com)
Copy link
No description provided.
Vylpes added this to the 3.5.0 milestone 2025-10-13 18:31:11 +01:00
Vylpes self-assigned this 2025-12-15 22:02:32 +00:00
Vylpes added this to the 3.3 Sprint 9 project 2025-12-15 22:02:33 +00:00
Vylpes stopped working 2025-12-23 15:53:53 +00:00
8 minutes 21 seconds
Vylpes removed their assignment 2026-09-16 13:25:19 +01:00
Smithy-bot removed their assignment 2026-09-22 12:05:43 +01:00
Smithy-bot commented 2026-09-22 12:05:43 +01:00
Member
Copy link

QA results — #153 (step/testing → step/uat)

Branch: release/3.5.0 @ 31250de
Landed via: PR #542 (merged 2026-09-16) — src/client/client.ts now rethrows after logging when AppDataSource.initialize() fails, so start() rejects before super.login().

Verification

Check Result
throw err present in initialize .catch PASS
AppDataSource.initialize() awaited before super.login() PASS
yarn build (tsc) PASS
yarn lint PASS
yarn test PASS — 3 suites / 29 tests / 1 snapshot

Notes

  • Issue has no formal acceptance criteria / test-plan scripts; verified against PR #542 intent (“Throw an exception if database cannot be connected to”).
  • Entry point (src/vylbot.ts) calls client.start() without an explicit .catch/exit — failure surfaces as a rejected/unhandled promise and Discord login is skipped. Manual smoke (bad DB creds → process does not stay connected to Discord) left for human UAT.

Assigning to @Vylpes for UAT.

## QA results — #153 (step/testing → step/uat) **Branch:** `release/3.5.0` @ `31250de` **Landed via:** PR #542 (merged 2026-09-16) — `src/client/client.ts` now rethrows after logging when `AppDataSource.initialize()` fails, so `start()` rejects before `super.login()`. ### Verification | Check | Result | | --- | --- | | `throw err` present in initialize `.catch` | PASS | | `AppDataSource.initialize()` awaited before `super.login()` | PASS | | `yarn build` (`tsc`) | PASS | | `yarn lint` | PASS | | `yarn test` | PASS — 3 suites / 29 tests / 1 snapshot | ### Notes - Issue has no formal acceptance criteria / test-plan scripts; verified against PR #542 intent (“Throw an exception if database cannot be connected to”). - Entry point (`src/vylbot.ts`) calls `client.start()` without an explicit `.catch`/exit — failure surfaces as a rejected/unhandled promise and Discord login is skipped. Manual smoke (bad DB creds → process does not stay connected to Discord) left for human UAT. Assigning to @Vylpes for UAT.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
release/3.4.0
feature/epic-528-rss-feeds
release/3.5.0
develop
v3.3.1
v3.3.0
v3.2.5
v3.2.4
v3.2.3
v3.2.2
v3.2.1
v3.2.0
v3.1.3
v3.1.2
v3.1.1
v3.1.0
v3.0.7
v3.0.6
v3.0.5
v3.1-alpha1
v3.0.4
v3.0.3
v3.0.2
v3.0.1
v3.0
v3.0-rc2
v3.0-rc1
v3.0-beta2
v3.0-beta1
v2.1.3
Labels
Clear labels
  
blocked

   
duplicate
  
needs
approval

  
needs
criteria

  
needs
estimate

  
needs
tests

  
question
  
step
doing

  
step
review

  
step
testing

  
step
todo

  
step
uat

  
type
admin

  
type
alert

  
type
bug

  
type
change

  
type
defect

  
type
dependencies

  
type
epic

  
type
idea

  
type
incident

  
type
investigation

  
type
spike

  
type
story

  
won't fix
No labels
blocked
duplicate
needs
approval
needs
criteria
needs
estimate
needs
tests
question
step
doing
step
review
step
testing
step
todo
step
uat
type
admin
type
alert
type
bug
type
change
type
defect
type
dependencies
type
epic
type
idea
type
incident
type
investigation
type
spike
type
story
won't fix
Milestone
Clear milestone
No items
No milestone
3.5.0
Projects
Clear projects
No items
No project
3.3 Sprint 9
Assignees
Clear assignees
No assignees
Vylpes
2 participants
Notifications
Total time spent: 8 minutes 21 seconds
Vylpes
8 minutes 21 seconds
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
RabbitLabs/vylbot-app#153
No description provided.