Vylpes changed title from ~~WIP: Use external Version constant and get from the workflow~~ to Use external Version constant and get from the workflow

2026-08-28 11:27:27 +01:00

Vylpes

2026-08-28 11:27:33 +01:00

added the
type
change
label
requested review from VylpesTester

VylpesTester was assigned by Vylpes

2026-08-28 11:28:18 +01:00

Vylpes requested review from Smithy-bot

2026-09-08 10:47:33 +01:00

Smithy-bot was assigned by Vylpes

2026-09-08 10:47:36 +01:00

Smithy-bot approved these changes

2026-09-08 12:03:29 +01:00

Smithy-bot left a comment

Approve — CI-driven CLI versioning looks good to merge.

What changed

Adds src/constants/Version.ts (defaults to 'local' for dev builds).
CLI reads the version from that constant instead of a hardcoded '2.4'.
publish.yml writes the tag name (stripping a leading v) before yarn build / yarn package.
staging.yml writes github.REF_NAME before packaging on develop/release/hotfix branches.

What looks good

Small, focused change with a sensible local-dev default.
Prod tag handling (v2.5.0 → 2.5.0) is correct.
Version injection happens in the package job after the test/build job, so unit tests still run against the committed 'local' default.

Non-blocking

Issue #260 still has "Add building CLI to the test flow" unchecked — test.yml does not run yarn package yet; fine as follow-up if you want CI to assert packaged binaries on feature branches.
Staging binaries will report the full branch name (e.g. release/2.5.0) rather than a semver; acceptable if that is intentional for stage artifacts.

No merge-blocking issues.

**Approve** — CI-driven CLI versioning looks good to merge. **What changed** - Adds `src/constants/Version.ts` (defaults to `'local'` for dev builds). - CLI reads the version from that constant instead of a hardcoded `'2.4'`. - `publish.yml` writes the tag name (stripping a leading `v`) before `yarn build` / `yarn package`. - `staging.yml` writes `github.REF_NAME` before packaging on develop/release/hotfix branches. **What looks good** - Small, focused change with a sensible local-dev default. - Prod tag handling (`v2.5.0` → `2.5.0`) is correct. - Version injection happens in the package job after the test/build job, so unit tests still run against the committed `'local'` default. **Non-blocking** - Issue #260 still has "Add building CLI to the test flow" unchecked — `test.yml` does not run `yarn package` yet; fine as follow-up if you want CI to assert packaged binaries on feature branches. - Staging binaries will report the full branch name (e.g. `release/2.5.0`) rather than a semver; acceptable if that is intentional for stage artifacts. No merge-blocking issues.

Vylpes merged commit 8d018549d8 into release/2.5.0

2026-09-08 14:23:51 +01:00

Vylpes deleted branch feature/260-package-version-ci

2026-09-08 14:23:51 +01:00

Vylpes referenced this pull request from a commit

2026-09-08 14:23:52 +01:00

Merge pull request 'Use external Version constant and get from the workflow' (#265) from feature/260-package-version-ci into release/2.5.0