RabbitLabs/random-bunny
5
0
Fork 0
Code Issues 6 Pull requests 1 Projects 1 Releases 18 Wiki Activity Actions

Fix bug where you weren't able to use both the -q and -j flags at the same time #227

Merged
Vylpes merged 17 commits from feature/181-q-json-flags into develop 2024-12-07 22:21:43 +00:00
Conversation 1 Commits 17 Files changed 3 +5 -7
2 changed files with 5 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 67e6c16028 - Show all commits

6
src/helpers/outputHelper.ts
View file

@ -22,13 +22,13 @@ export default class OutputHelper {
/* eslint-disable @typescript-eslint/no-explicit-any */
private static GetFriendlyObjectText(object: any): string {
Vylpes marked this conversation as resolved Outdated
Copilot commented 2024-11-18 20:51:36 +00:00
Outdated
Review
Copy link

[nitpick] The use of 'any' for the object parameter is not ideal. Consider using a more specific type.

[nitpick] The use of 'any' for the object parameter is not ideal. Consider using a more specific type.
let output = "";
const output: string[] = [];
Vylpes marked this conversation as resolved Outdated
VylpesTester commented 2024-10-26 21:58:16 +01:00
Outdated
Review
Copy link

I don't think I like the way this is done, I think it should be how it was before, but when its actually printed to the terminal it should remove the appended new line

I don't think I like the way this is done, I think it should be how it was before, but when its actually printed to the terminal it should remove the appended new line
Vylpes commented 2024-11-27 18:34:02 +00:00
Outdated
Review
Copy link

Not exactly sure what this means? It appears to be working fine and looks like that to me

Not exactly sure what this means? It appears to be working fine and looks like that to me
for (const key in object) {
output += `${key} = ${object[key]}\n`;
output.push(`${key} = ${object[key]}`);
Vylpes marked this conversation as resolved Outdated
VylpesTester commented 2024-10-19 20:35:10 +01:00
Outdated
Review
Copy link

This will add an additional new line at the end of the output which might not look right

This will add an additional new line at the end of the output which might not look right
}
return output;
return output.join("\n");
}
/* eslint-enable @typescript-eslint/no-explicit-any */
}

6
tests/helpers/__snapshots__/outputHelper.test.ts.snap
View file

@ -10,8 +10,7 @@ Subreddit = Rabbits
SubredditSubscribers = 654751
Title = This is my Ms Bear!
Ups = 17
Url = https://preview.redd.it/d5yno653zf7d1.jpg?width=640&crop=smart&auto=webp&s=5064d1caec3c12ac2855eb57ff131d0b313d5e9d
"
Url = https://preview.redd.it/d5yno653zf7d1.jpg?width=640&crop=smart&auto=webp&s=5064d1caec3c12ac2855eb57ff131d0b313d5e9d"
`;
exports[`GenerateOutput GIVEN options.json is true, EXPECT output to be returned as JSON 1`] = `"{"Archived":false,"Author":"author","Downs":0,"Hidden":false,"Permalink":"/r/Rabbits/comments/1dj8pbt/this_is_my_ms_bear/","Subreddit":"Rabbits","SubredditSubscribers":654751,"Title":"This is my Ms Bear!","Ups":17,"Url":"https://preview.redd.it/d5yno653zf7d1.jpg?width=640&crop=smart&auto=webp&s=5064d1caec3c12ac2855eb57ff131d0b313d5e9d"}"`;
@ -31,6 +30,5 @@ Ups = 17
Url = https://preview.redd.it/d5yno653zf7d1.jpg?width=640&crop=smart&auto=webp&s=5064d1caec3c12ac2855eb57ff131d0b313d5e9d
subreddit = rabbits
sortBy = hot
limit = 100
"
limit = 100"
`;