Fix bug where you weren't able to use both the -q and -j flags at the same time #227

Open
Vylpes wants to merge 3 commits from feature/181-q-json-flags into develop
Owner
  • Fix bug where if you supplied both -q/--query-metadata and -j/--json the query metadata wasn't added to the output
  • Update tests

#181

- Fix bug where if you supplied both `-q`/`--query-metadata` and `-j`/`--json` the query metadata wasn't added to the output - Update tests #181
Vylpes added 3 commits 2024-09-15 11:56:43 +01:00
Plan tests
All checks were successful
Test / build (push) Successful in 9s
ebf270f2bb
Update tests
All checks were successful
Test / build (push) Successful in 9s
bf026dae32
Vylpes requested review from VylpesTester 2024-09-15 11:56:47 +01:00
Vylpes added the
type
bug
label 2024-09-15 11:56:51 +01:00
VylpesTester was assigned by Vylpes 2024-09-15 11:56:53 +01:00
VylpesTester requested changes 2024-09-15 16:19:28 +01:00
@ -8,6 +8,15 @@ export default class OutputHelper {
const outputLines: string[] = [];
if (options.json) {
if (options.queryMetadata != null) {
Member

I feel like there could be a better way to do this? As now we have the output kinda splintered. I suggest maybe we have the json object created in a separate function, and then split to human-readable if -j isn't present

I feel like there could be a better way to do this? As now we have the output kinda splintered. I suggest maybe we have the json object created in a separate function, and then split to human-readable if `-j` isn't present
All checks were successful
Test / build (push) Successful in 9s
Required
Details
This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin feature/181-q-json-flags:feature/181-q-json-flags
git checkout feature/181-q-json-flags
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: RabbitLabs/random-bunny#227
No description provided.