Fix bug where you weren't able to use both the -q and -j flags at the same time #227
No reviewers
Labels
No labels
blocked
documentation
duplicate
enhancement
good first issue
help wanted
invalid
needs criteria
needs estimate
needs tests
question
spike
type
admin
type
alert
type
bug
type
defect
type
dependencies
type
epic
type
investigation
type
story
wontfix
blocked
duplicate
needs criteria
needs designs
needs estimate
needs testing
question
type
admin
type
alert
type
bug
type
defect
type
dependencies
type
design
type
documentation
type
epic
type
incident
type
investigation
type
spike
type
story
won't fix
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: RabbitLabs/random-bunny#227
Loading…
Reference in a new issue
No description provided.
Delete branch "feature/181-q-json-flags"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
-q
/--query-metadata
and-j
/--json
the query metadata wasn't added to the output#181
@ -8,6 +8,15 @@ export default class OutputHelper {
const outputLines: string[] = [];
if (options.json) {
if (options.queryMetadata != null) {
I feel like there could be a better way to do this? As now we have the output kinda splintered. I suggest maybe we have the json object created in a separate function, and then split to human-readable if
-j
isn't present@ -33,0 +25,4 @@
let output = "";
for (const key in object) {
output += `${key} = ${object[key]}\n`;
This will add an additional new line at the end of the output which might not look right
@ -33,0 +22,4 @@
/* eslint-disable @typescript-eslint/no-explicit-any */
private static GetFriendlyObjectText(object: any): string {
const output: string[] = [];
I don't think I like the way this is done, I think it should be how it was before, but when its actually printed to the terminal it should remove the appended new line
Not exactly sure what this means? It appears to be working fine and looks like that to me
See above
@ -32,1 +21,4 @@
}
/* eslint-disable @typescript-eslint/no-explicit-any */
private static GetFriendlyObjectText(object: any): string {
[nitpick] The use of 'any' for the object parameter is not ideal. Consider using a more specific type.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no suggestions.
@ -106,7 +106,7 @@ describe("GenerateOutput", () => {
expect(result).toMatchSnapshot();
});
test("GIVEN the Gallery input has more than 1 item, EXPECT Gallery line to be added", () => {
Why don't we want this test anymore? Surely thats still a good thing to test?