Fix bug where you weren't able to use both the -q and -j flags at the same time #227

					
				@ -8,6 +8,15 @@ export default class OutputHelper {

				        const outputLines: string[] = [];

				        if (options.json) {

				            if (options.queryMetadata != null) {

VylpesTester commented

2024-09-15 16:19:09 +01:00

I feel like there could be a better way to do this? As now we have the output kinda splintered. I suggest maybe we have the json object created in a separate function, and then split to human-readable if -j isn't present

I feel like there could be a better way to do this? As now we have the output kinda splintered. I suggest maybe we have the json object created in a separate function, and then split to human-readable if `-j` isn't present

Vylpes marked this conversation as resolved

Vylpes added 3 commits 2024-10-18 18:58:03 +01:00

Merge branch 'develop' into feature/181-q-json-flags f4d447f66f

Simplify outputHelper abac3442c4

Fix linter

Test / build (push) Successful in 14s

Details

49d986de05

Vylpes added 1 commit 2024-10-18 19:12:20 +01:00

New line the return statement

Test / build (push) Successful in 8s

Details

3b284484c2

Vylpes added 1 commit 2024-10-18 19:27:36 +01:00

Make object flat

Test / build (push) Failing after 9s

Details

438884b270

Vylpes added 1 commit 2024-10-18 19:28:21 +01:00

Fix linting

Test / build (push) Successful in 8s

Details

eb09754e2e

VylpesTester requested changes 2024-10-19 20:35:23 +01:00

Dismissed

src/helpers/outputHelper.ts Outdated

					
				@ -33,0 +25,4 @@

				        let output = "";

				        for (const key in object) {

				            output += `${key} = ${object[key]}\n`;

VylpesTester commented

2024-10-19 20:35:10 +01:00

This will add an additional new line at the end of the output which might not look right

Vylpes marked this conversation as resolved

Vylpes added 2 commits 2024-10-26 20:52:50 +01:00

Merge branch 'develop' into feature/181-q-json-flags 2d613d2109

Update output helper class to not append a new line right at the end of the output

Test / build (push) Successful in 9s

Details

67e6c16028

Vylpes requested review from VylpesTester 2024-10-26 20:53:03 +01:00

VylpesTester reviewed 2024-10-26 21:58:46 +01:00

src/helpers/outputHelper.ts

					
				@ -33,0 +22,4 @@

				    /* eslint-disable @typescript-eslint/no-explicit-any */

				    private static GetFriendlyObjectText(object: any): string {

				        const output: string[] = [];

VylpesTester commented

2024-10-26 21:58:16 +01:00

I don't think I like the way this is done, I think it should be how it was before, but when its actually printed to the terminal it should remove the appended new line

VylpesTester requested changes 2024-10-26 21:59:08 +01:00

VylpesTester left a comment

See above

Copilot reviewed 2024-11-18 20:50:30 +00:00

Vylpes requested review from Copilot 2024-11-18 20:51:07 +00:00

Copilot reviewed 2024-11-18 20:51:40 +00:00

src/helpers/outputHelper.ts

					
				@ -32,1 +21,4 @@

				    }

				    /* eslint-disable @typescript-eslint/no-explicit-any */

				    private static GetFriendlyObjectText(object: any): string {

Copilot commented

2024-11-18 20:51:36 +00:00

[nitpick] The use of 'any' for the object parameter is not ideal. Consider using a more specific type.

Vylpes removed review request for Copilot 2024-11-18 20:51:52 +00:00

Test / build (push) Successful in 9s

Required

Details

This pull request has changes conflicting with the target branch.

src/helpers/outputHelper.ts
tests/helpers/outputHelper.test.ts

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin feature/181-q-json-flags:feature/181-q-json-flags

git checkout feature/181-q-json-flags

Sign in to join this conversation.

No reviewers

No milestone

No project

No assignees

3 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: RabbitLabs/random-bunny#227