RabbitLabs/random-bunny
4
0
Fork 0
Code Issues 10 Pull requests 9 Projects 1 Releases 18 Wiki Activity Actions

Fix bug where you weren't able to use both the -q and -j flags at the same time #227

Open
Vylpes wants to merge 11 commits from feature/181-q-json-flags into develop
pull from: feature/181-q-json-flags
merge into: RabbitLabs:develop
Conversation 0 Commits 11 Files changed 3 +3 -1
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 49d986de05 - Show all commits

4
src/helpers/outputHelper.ts
View file

@ -20,8 +20,9 @@ export default class OutputHelper {
return this.GetFriendlyObjectText(outputObject, "");
}
/* eslint-disable @typescript-eslint/no-explicit-any */
private static GetFriendlyObjectText(object: any, output: string, prefix: string = ""): string {
for (let key in object) {
for (const key in object) {
VylpesTester commented 2024-10-26 21:58:16 +01:00
Review
Copy link

I don't think I like the way this is done, I think it should be how it was before, but when its actually printed to the terminal it should remove the appended new line

I don't think I like the way this is done, I think it should be how it was before, but when its actually printed to the terminal it should remove the appended new line
if (typeof(object[key]) == "object") return this.GetFriendlyObjectText(object[key], output, `${key}.`);
output += `${prefix}${key} = ${object[key]}\n`;
Vylpes marked this conversation as resolved Outdated
VylpesTester commented 2024-10-19 20:35:10 +01:00
Outdated
Review
Copy link

This will add an additional new line at the end of the output which might not look right

This will add an additional new line at the end of the output which might not look right
@ -34,4 +35,5 @@ export default class OutputHelper {
a[target] = { ...b };
return a;
}
/* eslint-enable @typescript-eslint/no-explicit-any */
}