RabbitLabs/calculator
Watch
5
0
Fork
You've already forked calculator
 0
Code Issues 22 Pull requests 1 Projects 1 Releases Packages Wiki Activity Actions

Add support for multiple operations in one expression #45

Open
Vylpes wants to merge 2 commits from feature/22-multiple-operations into release/0.1.0
pull from: feature/22-multiple-operations
merge into: RabbitLabs:release/0.1.0
Conversation 1 Commits 2 Files changed 4 +130 -47
Vylpes commented 2026-10-31 10:10:37 +00:00
Owner
Copy link

#22

#22
Fix bug in gui crashing with multiple operators
All checks were successful
Test / build (push) Successful in 2m8s
Details
ee5d5a7243
Vylpes 2026-10-31 10:12:35 +00:00
Smithy-bot approved these changes 2026-10-31 11:02:37 +00:00
Smithy-bot left a comment
Copy link

Approved for #22.

CLI evaluation now walks space-separated chains left-to-right with clear validation for odd token counts and trailing operators. README documents the no-precedence behavior with an example. GUI apply_operation folds pending ops before chaining (including keyboard paths) and handles divide-by-zero without leaving stale state. Tests cover chains, whitespace, and invalid input.

**Approved** for #22. CLI evaluation now walks space-separated chains left-to-right with clear validation for odd token counts and trailing operators. README documents the no-precedence behavior with an example. GUI `apply_operation` folds pending ops before chaining (including keyboard paths) and handles divide-by-zero without leaving stale state. Tests cover chains, whitespace, and invalid input.
All checks were successful
Test / build (push) Successful in 2m8s
Details
This pull request has changes conflicting with the target branch.
  • tests/calculator.rs
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin feature/22-multiple-operations:feature/22-multiple-operations
git switch feature/22-multiple-operations
Sign in to join this conversation.
Reviewers
No reviewers
Smithy-bot
Labels
Clear labels
  
blocked

   
duplicate

   
high priority
  
needs
approval

  
needs
criteria

  
needs
estimate

  
needs
tests

  
question
  
step
doing

  
step
review

  
step
testing

  
step
todo

  
step
uat

  
type
admin

  
type
alert

  
type
bug

  
type
change

  
type
defect

  
type
dependencies

  
type
development

  
type
documentation

  
type
epic

  
type
idea

  
type
incident

  
type
investigation

  
type
spike

  
type
story

  
type
tests

  
won't fix
No labels
blocked
duplicate
high priority
needs
approval
needs
criteria
needs
estimate
needs
tests
question
step
doing
step
review
step
testing
step
todo
step
uat
type
admin
type
alert
type
bug
type
change
type
defect
type
dependencies
type
development
type
documentation
type
epic
type
idea
type
incident
type
investigation
type
spike
type
story
type
tests
won't fix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
Smithy-bot
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
RabbitLabs/calculator!45
No description provided.