Start of give command multiple quantities #568

Merged
Vylpes merged 2 commits from feature/359-give-card-quantity into release/0.11.0 2026-10-20 12:15:38 +01:00
Owner
#359
WIP: Start of give command multiple quantities
All checks were successful
Test / build (push) Successful in 1m20s
750b41cdfe
Update changelog
All checks were successful
Test / build (push) Successful in 1m21s
cdee5530f1
Vylpes changed title from WIP: Start of give command multiple quantities to Start of give command multiple quantities 2026-10-19 21:49:14 +01:00
Smithy-bot approved these changes 2026-10-20 12:02:57 +01:00
Smithy-bot left a comment

Approved — /give card quantity support matches #359.

  • Optional quantity with setMinValue(1) and default 1 preserves today’s behaviour when omitted.
  • Inventory updates use AddQuantity / constructor initial quantity consistently; reply includes amount granted and new total.
  • New unit tests cover default quantity, explicit quantity, invalid/negative quantity, and existing admin/sync/safe-mode/card guards.

Nits (non-blocking): The PR title still says “Start of …” though the issue subtasks look complete; consider retitling before merge. The Unreleased changelog block bundles several unrelated entries beyond #359 — fine if this targets release/0.11.0, but worth keeping scoped if you prefer smaller PRs.

**Approved** — `/give card` quantity support matches #359. - Optional `quantity` with `setMinValue(1)` and default 1 preserves today’s behaviour when omitted. - Inventory updates use `AddQuantity` / constructor initial quantity consistently; reply includes amount granted and new total. - New unit tests cover default quantity, explicit quantity, invalid/negative quantity, and existing admin/sync/safe-mode/card guards. **Nits (non-blocking):** The PR title still says “Start of …” though the issue subtasks look complete; consider retitling before merge. The `Unreleased` changelog block bundles several unrelated entries beyond #359 — fine if this targets `release/0.11.0`, but worth keeping scoped if you prefer smaller PRs.
Vylpes merged commit ec12facdd7 into release/0.11.0 2026-10-20 12:15:38 +01:00
Vylpes deleted branch feature/359-give-card-quantity 2026-10-20 12:15:38 +01:00
Sign in to join this conversation.
No description provided.