External/card-drop
Watch
5
0
Fork
You've already forked card-drop
 0
Code Issues 60 Pull requests Projects 1 Releases 37 Packages Wiki Activity Actions

Log safemode errors #555

Merged
Vylpes merged 1 commit from feature/554-log-safemode-error into hotfix/0.10.1 2026-10-01 13:24:27 +01:00
Conversation 1 Commits 1 Files changed 4 +47 -7
Vylpes commented 2026-09-30 18:17:27 +01:00
Owner
Copy link

Log safemode errors so that its easier for maintainers to see when a card is wrong

#554

Log safemode errors so that its easier for maintainers to see when a card is wrong #554
Log safemode errors
All checks were successful
Test / build (push) Successful in 1m15s
Details
fa0f22525b
Vylpes changed title from WIP: Log safemode errors to Log safemode errors 2026-09-30 18:18:46 +01:00
Smithy-bot approved these changes 2026-10-01 12:03:09 +01:00
Smithy-bot left a comment
Copy link

Approved — this cleanly addresses #554 and improves operator visibility when safe mode engages.

Highlights:

  • CardMetadataFunction now logs the full file: message string when enabling safe mode (not just the message), and reuses the same errorMessage for the API response.
  • resync correctly gates on result.IsSuccess instead of truthiness on the result object — an important fix so failed runs are handled and logged.
  • gdrivesync / resync user-facing copy now states that safe mode was activated and surfaces ErrorMessage in the reply.
  • Tests cover safe-mode logging, Config.SetValue, and parse-failure paths.

No merge blockers from my side.

**Approved** — this cleanly addresses #554 and improves operator visibility when safe mode engages. **Highlights:** - `CardMetadataFunction` now logs the full `file: message` string when enabling safe mode (not just the message), and reuses the same `errorMessage` for the API response. - `resync` correctly gates on `result.IsSuccess` instead of truthiness on the result object — an important fix so failed runs are handled and logged. - `gdrivesync` / `resync` user-facing copy now states that safe mode was activated and surfaces `ErrorMessage` in the reply. - Tests cover safe-mode logging, `Config.SetValue`, and parse-failure paths. No merge blockers from my side.
Vylpes merged commit 63017d77c2 into hotfix/0.10.1 2026-10-01 13:24:27 +01:00
Vylpes deleted branch feature/554-log-safemode-error 2026-10-01 13:24:27 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Smithy-bot
Labels
Clear labels   
question
More information is needed

  
blocked

   
duplicate
This issue or pull request already exists

  
needs
approval

  
needs
criteria

  
needs
estimate

  
needs
tests

  
question
More information is needed

  
step
doing

  
step
review

  
step
testing

  
step
todo

  
step
uat

  
type
admin

  
type
alert

  
type
bug

  
type
change

  
type
defect

  
type
dependencies

  
type
epic

  
type
idea

  
type
incident

  
type
investigation

  
type
spike

  
type
story

  
wontfix
This won't be fixed

No labels
question
blocked
duplicate
needs
approval
needs
criteria
needs
estimate
needs
tests
question
step
doing
step
review
step
testing
step
todo
step
uat
type
admin
type
alert
type
bug
type
change
type
defect
type
dependencies
type
epic
type
idea
type
incident
type
investigation
type
spike
type
story
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
Smithy-bot
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
External/card-drop!555
No description provided.