External/card-drop
Watch
5
0
Fork
You've already forked card-drop
 0
Code Issues 36 Pull requests 4 Projects 1 Releases 35 Packages Wiki Activity Actions

Add validation on card metadata types #518

Merged
Vylpes merged 1 commit from feature/516-validate-card-metadata-types into release/0.12.0 2026-09-06 16:07:20 +01:00
Conversation 1 Commits 1 Files changed 4 +355 -2
Vylpes commented 2026-09-06 09:26:57 +01:00
Owner
Copy link

#516

#516
Add validation on card metadata types
All checks were successful
Test / build (push) Successful in 1m36s
Details
204b465932
Vylpes changed title from WIP: Add validation on card metadata types to Add validation on card metadata types 2026-09-06 09:30:17 +01:00
Smithy-bot approved these changes 2026-09-06 15:56:50 +01:00
Smithy-bot left a comment
Copy link

Approve — parse-time card metadata validation is well implemented and matches #516.

What looks good

  • New CardMetadataValidator enforces the right policy: type must be a JSON number in the CardRarity range (string "1" is rejected, not coerced), while series id numeric strings are coerced for legacy files.
  • Integration in CardMetadataFunction treats validation failures like corrupt JSON — logs the file path, aborts that load, and activates safe mode so invalid cards never reach drop/inventory/stats paths.
  • Error messages include file path plus series/card identifiers, satisfying the visibility requirement.
  • Unit tests cover valid numeric type, rejected string/null/garbage/out-of-range types, series id coercion, and non-array roots.
  • docs/cards.md documents the validation policy clearly.

Non-blocking

  • No integration test exercising CardMetadataFunction end-to-end with a bad file on disk; validator coverage is thorough enough for now.
  • A series with an empty cards array passes validation; fine if that is intentional.

No merge-blocking issues.

**Approve** — parse-time card metadata validation is well implemented and matches #516. **What looks good** - New `CardMetadataValidator` enforces the right policy: `type` must be a JSON number in the `CardRarity` range (string `"1"` is rejected, not coerced), while series `id` numeric strings are coerced for legacy files. - Integration in `CardMetadataFunction` treats validation failures like corrupt JSON — logs the file path, aborts that load, and activates safe mode so invalid cards never reach drop/inventory/stats paths. - Error messages include file path plus series/card identifiers, satisfying the visibility requirement. - Unit tests cover valid numeric `type`, rejected string/null/garbage/out-of-range types, series id coercion, and non-array roots. - `docs/cards.md` documents the validation policy clearly. **Non-blocking** - No integration test exercising `CardMetadataFunction` end-to-end with a bad file on disk; validator coverage is thorough enough for now. - A series with an empty `cards` array passes validation; fine if that is intentional. No merge-blocking issues.
Vylpes merged commit bd1cd3d8e3 into release/0.12.0 2026-09-06 16:07:20 +01:00
Vylpes deleted branch feature/516-validate-card-metadata-types 2026-09-06 16:07:20 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Smithy-bot
Labels
Clear labels
  
blocked

   
duplicate
This issue or pull request already exists

  
needs
approval

  
needs
criteria

  
needs
estimate

  
needs
tests

  
question
More information is needed

  
step
doing

  
step
review

  
step
testing

  
step
todo

  
step
uat

  
type
admin

  
type
alert

  
type
bug

  
type
change

  
type
defect

  
type
epic

  
type
idea

  
type
incident

  
type
investigation

  
type
spike

  
type
story

  
wontfix
This won't be fixed

No labels
blocked
duplicate
needs
approval
needs
criteria
needs
estimate
needs
tests
question
step
doing
step
review
step
testing
step
todo
step
uat
type
admin
type
alert
type
bug
type
change
type
defect
type
epic
type
idea
type
incident
type
investigation
type
spike
type
story
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
Smithy-bot
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
External/card-drop!518
No description provided.