Add a summary at the end of a multidrop queue #505

Merged

Vylpes merged 1 commit from feature/383-multidrop-summary into release/0.10.0

2026-08-30 08:40:07 +01:00

Vylpes commented

2026-07-30 20:14:58 +01:00

Owner

#383

Vylpes added the

type

story

label

2026-07-30 20:14:58 +01:00

Vylpes added 1 commit

2026-07-30 20:14:58 +01:00

Add a summary at the end of a multidrop queue

Test / build (push) Successful in 2m8s

Details

2628312dd6

Vylpes requested review from VylpesTester

2026-07-30 20:15:01 +01:00

VylpesTester was assigned by Vylpes

2026-07-30 20:15:04 +01:00

Smithy-bot was assigned by Vylpes

2026-08-29 15:06:22 +01:00

Vylpes requested reviews from Smithy-bot and removed review requests for VylpesTester

2026-08-30 08:30:36 +01:00

VylpesTester was unassigned by Vylpes

2026-08-30 08:31:13 +01:00

Smithy-bot approved these changes

2026-08-30 08:37:00 +01:00

Smithy-bot left a comment

Approve — multidrop summary persistence and cleanup look good to merge.

This adds a Multidrop entity/migration to track kept and sacrificed cards per session, switches button custom IDs from user ID to multidrop ID, shows a completion summary embed (kept, sacrificed, new balance), and purges expired sessions daily via PurgeMultidrops.

What looks good

Meets #383 acceptance criteria: DB storage, summary embed, expiry cleanup, and new tests.
Summary embed resolves card numbers to names with sensible fallbacks.
Record is created before deferReply, so button IDs always reference a persisted session.
Expiry constant (MultidropExpiry) and midnight purge timer follow existing patterns.

Non-blocking

In-flight multidrops started before deploy will fail lookup (expected migration).
Sacrifice completion path lacks a dedicated test (keep path is covered).

No merge-blocking issues.

**Approve** — multidrop summary persistence and cleanup look good to merge. This adds a `Multidrop` entity/migration to track kept and sacrificed cards per session, switches button custom IDs from user ID to multidrop ID, shows a completion summary embed (kept, sacrificed, new balance), and purges expired sessions daily via `PurgeMultidrops`. **What looks good** - Meets #383 acceptance criteria: DB storage, summary embed, expiry cleanup, and new tests. - Summary embed resolves card numbers to names with sensible fallbacks. - Record is created before `deferReply`, so button IDs always reference a persisted session. - Expiry constant (`MultidropExpiry`) and midnight purge timer follow existing patterns. **Non-blocking** - In-flight multidrops started before deploy will fail lookup (expected migration). - Sacrifice completion path lacks a dedicated test (keep path is covered). No merge-blocking issues.

Vylpes merged commit 5f7ea7739b into release/0.10.0

2026-08-30 08:40:07 +01:00

Vylpes deleted branch feature/383-multidrop-summary

2026-08-30 08:40:07 +01:00

Vylpes referenced this pull request from a commit

2026-08-30 08:40:08 +01:00

Merge pull request 'Add a summary at the end of a multidrop queue' (#505) from feature/383-multidrop-summary into release/0.10.0