Add failsafe error catch if card object is undefined during metadata initialisation #477

Approve with minor fixes - The core bug fix is solid and the tests are valuable. Just fix the typo in the function name and consider the validation ordering question.

I'll review this diff for you. This appears to be a bug fix with added test coverage for the `CardMetadataFunction`. ## Summary The changes fix a bug where only the first series in a JSON file was validated for cards, and adds comprehensive unit tests to prevent regression. ## Verdict **Approve with minor fixes** - The core bug fix is solid and the tests are valuable. Just fix the typo in the function name and consider the validation ordering question.

tests/__functions__/card-drop/GenerateSeriesMetadata.ts

					
				@ -0,0 +1,43 @@

				import {CardMetadata} from "../../../src/contracts/SeriesMetadata";

				// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Required to test non-confirmed json data

				export default function GenenerateSeriesMetadata(id: number, name: string, generateSeries: number = 1, generateCards: number | number[] = 1): any[] {

Typo in Function Name

Test / build (push) Successful in 55s

Details

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin feature/473-card-object-undefined:feature/473-card-object-undefined

git switch feature/473-card-object-undefined

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch release/0.10.0

git merge --no-ff feature/473-card-object-undefined

git switch feature/473-card-object-undefined

git rebase release/0.10.0

git switch release/0.10.0

git merge --ff-only feature/473-card-object-undefined

git switch feature/473-card-object-undefined

git rebase release/0.10.0

git switch release/0.10.0

git merge --no-ff feature/473-card-object-undefined

git switch release/0.10.0

git merge --squash feature/473-card-object-undefined