External/card-drop
5
0
Fork 0
Code Issues 41 Pull requests 1 Projects 1 Releases 34 Packages Wiki Activity Actions

Add failsafe error catch if card object is undefined during metadata initialisation #477

Merged
Vylpes merged 5 commits from feature/473-card-object-undefined into release/0.10.0 2025-12-01 22:02:40 +00:00
Conversation 2 Commits 5 Files changed 3 +173 -12
Vylpes commented 2025-11-12 18:06:43 +00:00
Owner
Copy link
  • Add unit tests for the failsafe

#473

- Add unit tests for the failsafe #473
Add unit tests for the failsafe on card object being undefined
Some checks failed
Test / build (push) Failing after 54s
Details
0029babb13
Fix tests
All checks were successful
Test / build (push) Successful in 53s
Details
52c6ecd1cd
Fix failsafe not taking into account if a json file has other series in it
All checks were successful
Test / build (push) Successful in 55s
Details
5d74e00357
Vylpes requested review from Copilot 2025-11-12 18:08:30 +00:00
Copilot requested changes 2025-11-12 18:16:25 +00:00
Dismissed
Copilot left a comment
Member
Copy link

I'll review this diff for you. This appears to be a bug fix with added test coverage for the CardMetadataFunction.

Summary

The changes fix a bug where only the first series in a JSON file was validated for cards, and adds comprehensive unit tests to prevent regression.

Verdict

Approve with minor fixes - The core bug fix is solid and the tests are valuable. Just fix the typo in the function name and consider the validation ordering question.

I'll review this diff for you. This appears to be a bug fix with added test coverage for the `CardMetadataFunction`. ## Summary The changes fix a bug where only the first series in a JSON file was validated for cards, and adds comprehensive unit tests to prevent regression. ## Verdict **Approve with minor fixes** - The core bug fix is solid and the tests are valuable. Just fix the typo in the function name and consider the validation ordering question.
tests/__functions__/card-drop/GenerateSeriesMetadata.ts Outdated
@ -0,0 +1,43 @@
import {CardMetadata} from "../../../src/contracts/SeriesMetadata";
// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Required to test non-confirmed json data
export default function GenenerateSeriesMetadata(id: number, name: string, generateSeries: number = 1, generateCards: number | number[] = 1): any[] {
Copilot commented 2025-11-12 18:12:11 +00:00
Member
Copy link

Typo in Function Name

Typo in Function Name
Vylpes marked this conversation as resolved
Fix typo
All checks were successful
Test / build (push) Successful in 52s
Details
448073c6cd
Vylpes dismissed Copilot's review 2025-11-22 10:14:20 +00:00
Vylpes merged commit 46cb8a84e7 into release/0.10.0 2025-12-01 22:02:40 +00:00
Vylpes deleted branch feature/473-card-object-undefined 2025-12-01 22:02:40 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Copilot
VylpesTester
Labels
Clear labels   
blocked

   
duplicate

   
needs criteria

   
needs estimate

   
needs tests

   
question

   
requires documentation
  
type
admin

  
type
alert

  
type
bug

  
type
change

  
type
defect

  
type
dependencies

  
type
epic

  
type
investigation

  
type
spike

  
type
story

  
type
subtask

  
won't fix
No labels
blocked
duplicate
needs criteria
needs estimate
needs tests
question
requires documentation
type
admin
type
alert
type
bug
type
change
type
defect
type
dependencies
type
epic
type
investigation
type
spike
type
story
type
subtask
won't fix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
VylpesTester
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
External/card-drop!477
No description provided.