External/card-drop

Fix remote image urls not showing up in image grids #427

Closed

Vylpes wants to merge 55 commits from feature/CD-425 into hotfix/0.8.4

Vylpes commented

2025-03-31 18:05:30 +01:00

Owner

Update the Image Grid helper to download images that are urls instead of trying (and failing) to load them locally

- Update the Image Grid helper to download images that are urls instead of trying (and failing) to load them locally #425

Vylpes added 1 commit 2025-03-31 18:05:31 +01:00

Fix remote image urls not showing up in image grids

Test / build (push) Successful in 39s

Details

requested review from VylpesTester

2025-03-31 18:05:39 +01:00

Vylpes added the

label 2025-03-31 18:05:44 +01:00

VylpesTester was assigned by Vylpes

2025-03-31 18:05:50 +01:00

VylpesTester requested changes 2025-04-15 17:35:04 +01:00

src/helpers/ImageHelper.ts

					
				@ -30,3 +31,3 @@

				            const filePath = path.join(process.env.DATA_DIR!, "cards", card.path);

				            const exists = existsSync(filePath);

				            const exists = existsSync(filePath) || card.path.startsWith("http://") || card.path.startsWith("https://");

VylpesTester commented

2025-04-15 17:34:15 +01:00

Member

Do we want to instead make the startsWith part its own variable? Might be a bit more readable and such IMO

Do we want to instead make the `startsWith` part its own variable? Might be a bit more readable and such IMO

src/helpers/ImageHelper.ts Outdated

					
				@ -32,3 +33,3 @@

				            const exists = existsSync(filePath);

				            const exists = existsSync(filePath) || card.path.startsWith("http://") || card.path.startsWith("https://");

				            if (!exists) {

VylpesTester commented

2025-04-15 17:34:57 +01:00

Member

This could also then be put into an if else chain in the if below

This could also then be put into an if else chain in the if below

Vylpes changed target branch from develop to main

2025-04-17 14:39:02 +01:00

Vylpes changed target branch from main to hotfix/0.8.4

2025-04-17 14:39:42 +01:00

Vylpes added 1 commit 2025-04-17 15:02:10 +01:00

Simplify image helper

Test / build (push) Successful in 42s

Details

Vylpes closed this pull request

2025-04-17 15:02:44 +01:00

Test / build (push) Successful in 42s

Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

No reviewers

No labels

requires documentation

No milestone

No project

No assignees

2 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: External/card-drop#427

No description provided.