External/card-drop
5
0
Fork 0
Code Issues 44 Pull requests Projects 1 Releases 29 Packages Wiki Activity Actions

Add friendly name and active effect to user effect list embed #422

Merged
Vylpes merged 5 commits from feature/379-2 into develop 2025-02-03 18:24:27 +00:00
Conversation 0 Commits 5 Files changed 5 +361 -21
Vylpes commented 2025-01-29 18:12:06 +00:00
Owner
Copy link

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

  • Add friendly name to list embed
  • Add currently active effect to list

#379

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify the changes. Provide instructions so we can reproduce. Please also list any relevant details to your test configuration.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that provde my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
# Description Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. - Add friendly name to list embed - Add currently active effect to list #379 ## Type of change Please delete options that are not relevant. - [x] New feature (non-breaking change which adds functionality) # How Has This Been Tested? Please describe the tests that you ran to verify the changes. Provide instructions so we can reproduce. Please also list any relevant details to your test configuration. # Checklist - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that provde my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules
Vylpes added the
type
story
 label 2025-01-29 18:12:06 +00:00
Vylpes added 3 commits 2025-01-29 18:12:06 +00:00
Fix linter
All checks were successful
Test / build (push) Successful in 36s
Details
37346aaede
Copilot requested changes 2025-01-29 18:13:08 +00:00
Dismissed
Copilot left a comment
Member
Copy link

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • tests/helpers/snapshots/EffectHelper.test.ts.snap: Language not supported
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment. <details> <summary>Files not reviewed (1)</summary> * **tests/helpers/__snapshots__/EffectHelper.test.ts.snap**: Language not supported </details>
src/database/entities/app/UserEffect.ts Outdated
@ -74,0 +77,4 @@
const query = await repository.createQueryBuilder("effect")
.where("effect.UserId = :userId", { userId })
.where("effect.WhenExpires IS NOT NULL")
Copilot commented 2025-01-29 18:13:00 +00:00
Member
Copy link

Incorrect use of where clause. The second where should be andWhere to ensure the query is constructed correctly.

            .andWhere("effect.WhenExpires IS NOT NULL")
Incorrect use of `where` clause. The second `where` should be `andWhere` to ensure the query is constructed correctly. ```suggestion .andWhere("effect.WhenExpires IS NOT NULL") ```
Vylpes marked this conversation as resolved
Vylpes added 1 commit 2025-02-01 16:40:18 +00:00
Fix changes requested
All checks were successful
Test / build (push) Successful in 36s
Details
7c17e1d0d0
Vylpes dismissed Copilot's review 2025-02-01 16:40:27 +00:00
Vylpes requested review from VylpesTester 2025-02-01 16:41:05 +00:00
VylpesTester was assigned by Vylpes 2025-02-01 16:41:10 +00:00
Vylpes changed title from WIP: Add friendly name and active effect to user effect list embed to Add friendly name and active effect to user effect list embed 2025-02-01 16:41:17 +00:00
Vylpes added 1 commit 2025-02-03 18:23:33 +00:00
Split expiry date to its own field
All checks were successful
Test / build (push) Successful in 34s
Details
a050dd7131
VylpesTester approved these changes 2025-02-03 18:24:20 +00:00
Vylpes merged commit c6b458199c into develop 2025-02-03 18:24:27 +00:00
Vylpes deleted branch feature/379-2 2025-02-03 18:24:27 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
VylpesTester
Labels
Clear labels   
blocked

   
duplicate

   
needs criteria

   
needs estimate

   
needs tests

   
question

   
requires documentation
  
type
admin

  
type
alert

  
type
bug

  
type
change

  
type
defect

  
type
dependencies

  
type
epic

  
type
spike

  
type
story

  
type
subtask

  
won't fix
No labels
blocked
duplicate
needs criteria
needs estimate
needs tests
question
requires documentation
type
admin
type
alert
type
bug
type
change
type
defect
type
dependencies
type
epic
type
spike
type
story
type
subtask
won't fix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
VylpesTester
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: External/card-drop#422
No description provided.
Delete branch "feature/379-2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?