External/card-drop
5
0
Fork 0
Code Issues 45 Pull requests Projects 1 Releases 28 Packages Wiki Activity Actions

Create list effects command #412

Merged
Vylpes merged 15 commits from feature/379-list-effects into develop 2024-12-07 22:32:20 +00:00
Conversation 0 Commits 15 Files changed 10 +2 -2
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 399e9af75a - Show all commits

2
src/commands/effects.ts
View file

@ -33,7 +33,7 @@ export default class Effects extends Command {
private async List(interaction: CommandInteraction) { private async List(interaction: CommandInteraction) {
const pageOption = interaction.options.get("page"); const pageOption = interaction.options.get("page");
const page = pageOption && Number(pageOption.value) ? Number(pageOption.value) : 1; const page = !isNaN(Number(pageOption?.value)) ? Number(pageOption?.value) : 1;
const result = await EffectHelper.GenerateEffectEmbed(interaction.user.id, page); const result = await EffectHelper.GenerateEffectEmbed(interaction.user.id, page);

2
src/helpers/EffectHelper.ts
View file

@ -80,7 +80,7 @@ export default class EffectHelper {
.setCustomId(`effects list ${page - 1}`) .setCustomId(`effects list ${page - 1}`)
.setLabel("Previous") .setLabel("Previous")
.setStyle(ButtonStyle.Primary) .setStyle(ButtonStyle.Primary)
.setDisabled(page - 1 == 0), .setDisabled(page == 1),
Vylpes marked this conversation as resolved Outdated
Copilot commented 2024-12-06 18:12:26 +00:00
Outdated
Review
Copy link

The 'Previous' button should be disabled when 'page' is 1, not 0.

The 'Previous' button should be disabled when 'page' is 1, not 0.
new ButtonBuilder() new ButtonBuilder()
.setCustomId(`effects list ${page + 1}`) .setCustomId(`effects list ${page + 1}`)
.setLabel("Next") .setLabel("Next")