Create list effects command #412

Vylpes · 2024-11-30T16:16:48Z

Vylpes commented

2024-11-30 16:16:48 +00:00

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

#379

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify the changes. Provide instructions so we can reproduce. Please also list any relevant details to your test configuration.

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that provde my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules

# Description Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. #379 ## Type of change Please delete options that are not relevant. - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update # How Has This Been Tested? Please describe the tests that you ran to verify the changes. Provide instructions so we can reproduce. Please also list any relevant details to your test configuration. # Checklist - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that provde my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules

Vylpes added 7 commits 2024-11-30 16:16:48 +00:00

Create base effects command 1be9ba23a3

WIP: Start creating user effects builder

Test / build (push) Failing after 19s

Details

9fce79579b

Create embed helper function 96bbd3b28a

Create row helper function 78fcdeeca5

WIP: Start of list command

Test / build (push) Failing after 12s

Details

0e1bc43ac4

Create effects list subcommand 3873983b32

Create paginated button event

Test / build (push) Successful in 12s

Details

7944b3aeac

Vylpes added the

type

story

label 2024-11-30 16:16:53 +00:00

Vylpes added 2 commits 2024-11-30 16:38:06 +00:00

Fix embed pagination buttons 2a7006229a

Plan tests

Test / build (push) Successful in 13s

Details

6e6b2a0af6

Vylpes added 2 commits 2024-12-01 20:13:28 +00:00

Update effects buttonEvents tests 882387438e

WIP: Start updating effects command tests

Test / build (push) Failing after 19s

Details

32cc731442

Vylpes added 2 commits 2024-12-02 18:57:18 +00:00

Add effects command tests 5302d57a89

Update tests

Test / build (push) Failing after 14s

Details

0584d0304b

Vylpes added 1 commit 2024-12-06 18:08:19 +00:00

Fix linting

Test / build (push) Successful in 15s

Details

7429500540

Vylpes requested review from Copilot 2024-12-06 18:10:09 +00:00

Copilot reviewed 2024-12-06 18:12:38 +00:00

Copilot left a comment

Copilot reviewed 5 out of 10 changed files in this pull request and generated 1 suggestion.

Files not reviewed (5)

tests/commands/snapshots/effects.test.ts.snap: Language not supported
tests/helpers/snapshots/EffectHelper.test.ts.snap: Language not supported
src/buttonEvents/Effects.ts: Evaluated as low risk
src/database/entities/app/UserEffect.ts: Evaluated as low risk
src/registry.ts: Evaluated as low risk

Comments skipped due to low confidence (2)

src/commands/effects.ts:36

Use isNaN(Number(pageOption.value)) to check for invalid numbers.

const page = pageOption && Number(pageOption.value) ? Number(pageOption.value) : 1;

src/helpers/EffectHelper.ts:88

The 'Next' button should be disabled when 'page' is equal to 'totalPages'.

.setDisabled(page == totalPages)

Copilot reviewed 5 out of 10 changed files in this pull request and generated 1 suggestion. <details> <summary>Files not reviewed (5)</summary> * **tests/commands/__snapshots__/effects.test.ts.snap**: Language not supported * **tests/helpers/__snapshots__/EffectHelper.test.ts.snap**: Language not supported * **src/buttonEvents/Effects.ts**: Evaluated as low risk * **src/database/entities/app/UserEffect.ts**: Evaluated as low risk * **src/registry.ts**: Evaluated as low risk </details> <details> <summary>Comments skipped due to low confidence (2)</summary> **src/commands/effects.ts:36** * Use isNaN(Number(pageOption.value)) to check for invalid numbers. ``` const page = pageOption && Number(pageOption.value) ? Number(pageOption.value) : 1; ``` **src/helpers/EffectHelper.ts:88** * The 'Next' button should be disabled when 'page' is equal to 'totalPages'. ``` .setDisabled(page == totalPages) ``` </details>

src/helpers/EffectHelper.ts Outdated

					
				@ -49,0 +80,4 @@

				                    .setCustomId(`effects list ${page - 1}`)

				                    .setLabel("Previous")

				                    .setStyle(ButtonStyle.Primary)

				                    .setDisabled(page - 1 == 0),