Add ability to sacrifice multiple cards at once #354

Vylpes · 2024-09-06T18:11:27+01:00

Vylpes commented

2024-09-06 18:11:27 +01:00

The /sacrifice command now accepts an optional parameter to be able to specify the quantity
The Sacrifice button event now accepts a parameter to specify the quantity, this one is required but the command will default it to 1 if not supplied

- The `/sacrifice` command now accepts an optional parameter to be able to specify the quantity - The `Sacrifice` button event now accepts a parameter to specify the quantity, this one is required but the command will default it to 1 if not supplied #337

Vylpes added 3 commits 2024-09-06 18:11:27 +01:00

Update the sacrifice command to allow input of quantity

Test / build (push) Successful in 8s

Details

9f5042d696

Update the button events to take into account the quantity field 7106b16aec

Add default if not supplied

Test / build (push) Successful in 8s

Details

f086ca4bda

Vylpes requested review from VylpesTester 2024-09-06 18:11:31 +01:00

Vylpes added the

type

change

label 2024-09-06 18:11:33 +01:00

VylpesTester was assigned by Vylpes

2024-09-06 18:11:37 +01:00

VylpesTester requested changes 2024-09-07 16:54:31 +01:00

Dismissed

src/buttonEvents/Sacrifice.ts Outdated

					
				@ -23,6 +23,7 @@ export default class Sacrifice extends ButtonEvent {

				    private async confirm(interaction: ButtonInteraction) {

				        const userId = interaction.customId.split(" ")[2];

				        const cardNumber = interaction.customId.split(" ")[3];

				        const quantity = Number(interaction.customId.split(" ")[4]) ?? 1;

VylpesTester commented

2024-09-07 16:51:50 +01:00

I don't actually think this works, try using || instead of ??

I don't actually think this works, try using `||` instead of `??`

Vylpes marked this conversation as resolved

src/buttonEvents/Sacrifice.ts Outdated

					
				@ -98,6 +105,7 @@ export default class Sacrifice extends ButtonEvent {

				    private async cancel(interaction: ButtonInteraction) {

				        const userId = interaction.customId.split(" ")[2];

				        const cardNumber = interaction.customId.split(" ")[3];

				        const quantity = Number(interaction.customId.split(" ")[4]) ?? 1;

VylpesTester commented

2024-09-07 16:52:59 +01:00

Same here

Vylpes marked this conversation as resolved

src/commands/sacrifice.ts Outdated

					
				@ -21,3 +25,4 @@

				    public override async execute(interaction: CommandInteraction<CacheType>): Promise<void> {

				        const cardnumber = interaction.options.get("cardnumber", true);

				        const quantity = interaction.options.get("quantity")?.value as number ?? 1;