Add a warning to the logs if an ID is used twice #248

Merged
Vylpes merged 1 commit from feature/233-log-id-duplicate into develop 2024-06-01 14:52:39 +01:00
Owner

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

  • Make the bot log a warning if the card metadata function finds duplicated ids

#233

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify the changes. Provide instructions so we can reproduce. Please also list any relevant details to your test configuration.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that provde my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
# Description Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. - Make the bot log a warning if the card metadata function finds duplicated ids #233 ## Type of change Please delete options that are not relevant. - [x] New feature (non-breaking change which adds functionality) # How Has This Been Tested? Please describe the tests that you ran to verify the changes. Provide instructions so we can reproduce. Please also list any relevant details to your test configuration. # Checklist - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that provde my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules
Vylpes added 1 commit 2024-05-31 17:56:52 +01:00
Add a warning to the logs if an ID is used twice
All checks were successful
Test / build (push) Successful in 2m28s
876f2c53f5
Vylpes requested review from VylpesTester 2024-05-31 17:57:24 +01:00
Vylpes added the
type
spike
label 2024-05-31 17:57:37 +01:00
VylpesTester was assigned by Vylpes 2024-05-31 17:57:53 +01:00
VylpesTester approved these changes 2024-06-01 14:52:25 +01:00
Vylpes merged commit 6b9d71758a into develop 2024-06-01 14:52:39 +01:00
Vylpes deleted branch feature/233-log-id-duplicate 2024-06-01 14:52:39 +01:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: External/card-drop#248
No description provided.