Fix inventory showing quantities set to 0 #239

Merged
Vylpes merged 2 commits from feature/227-inventory-0-bug into develop 2024-05-24 17:50:35 +01:00
Owner

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

  • Fix a bug where the inventory would show a "x0" quantity when there were entities in the database with a current quantity of 0.
  • This occurs when you sacrifice cards, that command can't delete the row as it has claims connected to it in another table, so we need to maintain that key.

#227

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify the changes. Provide instructions so we can reproduce. Please also list any relevant details to your test configuration.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that provde my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
# Description Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. - Fix a bug where the inventory would show a "x0" quantity when there were entities in the database with a current quantity of 0. - This occurs when you sacrifice cards, that command can't delete the row as it has claims connected to it in another table, so we need to maintain that key. #227 ## Type of change Please delete options that are not relevant. - [x] Bug fix (non-breaking change which fixes an issue) # How Has This Been Tested? Please describe the tests that you ran to verify the changes. Provide instructions so we can reproduce. Please also list any relevant details to your test configuration. # Checklist - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that provde my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules
Vylpes added 1 commit 2024-05-24 17:28:13 +01:00
Fix inventory showing quantities set to 0
All checks were successful
Test / build (push) Successful in 2m29s
28c3bdae12
Vylpes requested review from VylpesTester 2024-05-24 17:28:16 +01:00
Vylpes added the
type
bug
label 2024-05-24 17:28:20 +01:00
VylpesTester was assigned by Vylpes 2024-05-24 17:28:24 +01:00
VylpesTester added 1 commit 2024-05-24 17:49:16 +01:00
Merge branch 'develop' into feature/227-inventory-0-bug
All checks were successful
Test / build (push) Successful in 14s
93d13e8dc6
VylpesTester approved these changes 2024-05-24 17:50:05 +01:00
Vylpes merged commit aa1ee5588a into develop 2024-05-24 17:50:35 +01:00
Vylpes deleted branch feature/227-inventory-0-bug 2024-05-24 17:50:35 +01:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: External/card-drop#239
No description provided.