Change sacrifice command embed colours to go green when successful from red #237

Merged
Vylpes merged 4 commits from feature/230-sacrifice-changes into develop 2024-05-24 17:45:58 +01:00
Owner

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

  • Update the sacrifice command so that the embed starts red, goes grey if cancelled, and goes green if successful
  • Fix event not checking if the user who ran the command is the same user who clicked the button
  • Remove duplicated card name in the embed, didn't need it in the footer as well as the main body

#203, #230, #238

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify the changes. Provide instructions so we can reproduce. Please also list any relevant details to your test configuration.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that provde my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
# Description Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. - Update the sacrifice command so that the embed starts red, goes grey if cancelled, and goes green if successful - Fix event not checking if the user who ran the command is the same user who clicked the button - Remove duplicated card name in the embed, didn't need it in the footer as well as the main body #203, #230, #238 ## Type of change Please delete options that are not relevant. - [x] New feature (non-breaking change which adds functionality) # How Has This Been Tested? Please describe the tests that you ran to verify the changes. Provide instructions so we can reproduce. Please also list any relevant details to your test configuration. # Checklist - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that provde my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules
Vylpes added 1 commit 2024-05-23 17:54:54 +01:00
Change sacrifice command embed colours to go green when successful from red
All checks were successful
Test / build (push) Successful in 2m29s
2eedaec2e3
Vylpes requested review from VylpesTester 2024-05-23 17:54:57 +01:00
Vylpes added the
type
subtask
label 2024-05-23 17:55:01 +01:00
VylpesTester was assigned by Vylpes 2024-05-23 17:55:03 +01:00
Vylpes added 1 commit 2024-05-23 17:59:55 +01:00
Vylpes added 1 commit 2024-05-23 18:00:58 +01:00
Remove duplicated card name
All checks were successful
Test / build (push) Successful in 10s
169bc62cca
VylpesTester added 1 commit 2024-05-24 17:44:46 +01:00
Merge branch 'develop' into feature/230-sacrifice-changes
All checks were successful
Test / build (push) Successful in 10s
2077bdf33b
VylpesTester approved these changes 2024-05-24 17:45:43 +01:00
Vylpes merged commit 5f513d740e into develop 2024-05-24 17:45:58 +01:00
Vylpes deleted branch feature/230-sacrifice-changes 2024-05-24 17:45:58 +01:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: External/card-drop#237
No description provided.