External/card-drop
4
0
Fork 0
Code Issues 44 Pull requests 7 Projects 1 Releases 28 Packages Wiki Activity Actions

Add cron job to add coins to a user every 30 minutes #219

Merged
Vylpes merged 7 commits from feature/204-coins-cron into develop 2024-05-17 20:57:01 +01:00
Conversation 0 Commits 7 Files changed 10 +138 -10
Vylpes commented 2024-05-06 17:14:10 +01:00
Owner
Copy link

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

  • Added a timer helper to run timers on a cron job
  • Added a currency timer function to give a user 5 currency every 30 minutes

#204

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify the changes. Provide instructions so we can reproduce. Please also list any relevant details to your test configuration.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that provde my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
# Description Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. - Added a timer helper to run timers on a cron job - Added a currency timer function to give a user 5 currency every 30 minutes #204 ## Type of change Please delete options that are not relevant. - [x] New feature (non-breaking change which adds functionality) # How Has This Been Tested? Please describe the tests that you ran to verify the changes. Provide instructions so we can reproduce. Please also list any relevant details to your test configuration. # Checklist - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that provde my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules
Vylpes added 3 commits 2024-05-06 17:14:10 +01:00
Create timer helper
All checks were successful
Test / build (push) Successful in 2m28s
Details
d4081a4f51
Add give currency timer
All checks were successful
Test / build (push) Successful in 2m29s
Details
c1ca37283c
Vylpes requested review from VylpesTester 2024-05-06 17:14:16 +01:00
Vylpes added the
type
story
 label 2024-05-06 17:14:19 +01:00
VylpesTester was assigned by Vylpes 2024-05-06 17:14:22 +01:00
VylpesTester requested changes 2024-05-11 12:54:25 +01:00
Dismissed
src/bot.ts Outdated
@ -4,6 +4,8 @@ import { IntentsBitField } from "discord.js";
import Registry from "./registry";
import { existsSync } from "fs";
import { ExecException, exec } from "child_process";
import TimerHelper from "./helpers/TimerHelper";
VylpesTester commented 2024-05-11 12:52:24 +01:00
Member
Copy link

Remove unnecessary imports

Remove unnecessary imports
Vylpes marked this conversation as resolved
src/registry.ts Outdated
@ -53,2 +53,4 @@
CoreClient.RegisterButtonEvent("trade", new TradeButtonEvent());
}
public static RegisterTimers() {
VylpesTester commented 2024-05-11 12:54:14 +01:00
Member
Copy link

Need to do something with this function

Need to do something with this function
Vylpes marked this conversation as resolved
Vylpes added 2 commits 2024-05-15 17:55:20 +01:00
Fix requested changes
Some checks failed
Test / build (push) Failing after 2m28s
Details
25d099928f
Vylpes added 2 commits 2024-05-15 18:06:25 +01:00
Fix linting issues
All checks were successful
Test / build (push) Successful in 2m30s
Details
30c62bd94d
Vylpes requested review from VylpesTester 2024-05-15 18:09:03 +01:00
VylpesTester approved these changes 2024-05-17 20:56:42 +01:00
Vylpes merged commit 836a1d341f into develop 2024-05-17 20:57:01 +01:00
Vylpes deleted branch feature/204-coins-cron 2024-05-17 20:57:01 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
VylpesTester
Labels
Clear labels   
blocked

   
duplicate

   
needs criteria

   
needs estimate

   
needs testing

   
question

   
requires documentation
  
type
admin

  
type
alert

  
type
bug

  
type
change

  
type
defect

  
type
dependencies

  
type
epic

  
type
spike

  
type
story

  
type
subtask

  
won't fix
No labels
blocked
duplicate
needs criteria
needs estimate
needs testing
question
requires documentation
type
admin
type
alert
type
bug
type
change
type
defect
type
dependencies
type
epic
type
spike
type
story
type
subtask
won't fix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
VylpesTester
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: External/card-drop#219
No description provided.
Delete branch "feature/204-coins-cron"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?