Create concept of currency in the database #209

Vylpes · 2024-04-16T19:08:20+01:00

Vylpes commented

2024-04-16 19:08:20 +01:00

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Create the concept of currency in the database

#200

Type of change

Please delete options that are not relevant.

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify the changes. Provide instructions so we can reproduce. Please also list any relevant details to your test configuration.

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that provde my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules

# Description Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. - Create the concept of currency in the database #200 ## Type of change Please delete options that are not relevant. - [x] New feature (non-breaking change which adds functionality) # How Has This Been Tested? Please describe the tests that you ran to verify the changes. Provide instructions so we can reproduce. Please also list any relevant details to your test configuration. # Checklist - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that provde my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules

Vylpes added 3 commits 2024-04-16 19:08:20 +01:00

Create users entity ea27bed454

Create migration script d608e1c752

Fix linting issues

ci/woodpecker/push/woodpecker Pipeline was successful

Details

ci/woodpecker/pr/woodpecker Pipeline was successful

Details

6c2233790e

Vylpes requested review from VylpesTester 2024-04-16 19:08:23 +01:00

Vylpes added the

type

story

label 2024-04-16 19:08:28 +01:00

VylpesTester was assigned by Vylpes

2024-04-16 19:08:32 +01:00

VylpesTester requested changes 2024-04-19 18:37:20 +01:00

Dismissed

src/database/entities/app/User.ts

					
				@ -0,0 +7,4 @@

				    constructor(userId: string, currency: number) {

				        super();

				        this.UserId = userId;

VylpesTester commented

2024-04-19 18:36:58 +01:00

Would it be worth having this as the main primary key ID? I can't see that not being unique

Vylpes marked this conversation as resolved

src/database/entities/app/User.ts Outdated

					
				@ -0,0 +21,4 @@

				        this.Currency = currency;

				    }

				    public static async FetchOneByUserId(userId: string): Promise<User | null> {