Update claim event to increment the claimed number when the user claims a drop #191

Merged
Vylpes merged 1 commit from feature/89-claim-increment into develop 2024-03-31 15:51:10 +01:00
Owner

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

  • Update the claim event to increment the claim number when the user claims a drop
  • Due to discord api limitations I can't reply to an interaction and edit the embed, so I've had to change it so the claimed by is displayed in the same embed
  • This also has the nice side effect of letting me disable the claim button as well

#89

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality

How Has This Been Tested?

Please describe the tests that you ran to verify the changes. Provide instructions so we can reproduce. Please also list any relevant details to your test configuration.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that provde my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
# Description Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. - Update the claim event to increment the claim number when the user claims a drop - Due to discord api limitations I can't reply to an interaction and edit the embed, so I've had to change it so the claimed by is displayed in the same embed - This also has the nice side effect of letting me disable the claim button as well #89 ## Type of change Please delete options that are not relevant. - [x] New feature (non-breaking change which adds functionality # How Has This Been Tested? Please describe the tests that you ran to verify the changes. Provide instructions so we can reproduce. Please also list any relevant details to your test configuration. # Checklist - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that provde my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules
Vylpes added 1 commit 2024-03-29 18:18:10 +00:00
Update claim event to increment the claimed number when the user claims a drop
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
ci/woodpecker/pr/woodpecker Pipeline was successful
ci/woodpecker/pull_request_closed/woodpecker Pipeline was successful
18c678a0ca
Vylpes requested review from VylpesTester 2024-03-29 18:18:12 +00:00
Vylpes added the
type
story
label 2024-03-29 18:18:15 +00:00
VylpesTester was assigned by Vylpes 2024-03-29 18:18:18 +00:00
VylpesTester approved these changes 2024-03-31 15:51:01 +01:00
Vylpes merged commit c7b01c932e into develop 2024-03-31 15:51:10 +01:00
Vylpes deleted branch feature/89-claim-increment 2024-03-31 15:51:11 +01:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: External/card-drop#191
No description provided.