External/card-drop
5
0
Fork 0
Code Issues 45 Pull requests Projects 1 Releases 28 Packages Wiki Activity Actions

Update drone script to use rsync #121

Merged
Vylpes merged 4 commits from feature/56-drone-rsync into develop 2023-12-29 19:52:00 +00:00
Conversation 0 Commits 4 Files changed 9 +58 -25
Vylpes commented 2023-12-21 16:28:55 +00:00
Owner
Copy link

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

  • Update drone pipelines to use resync

NOTE: This requires a new repository secret - ssh_key

NOTE: This requires moving the cards directory into the new appdata folder

#56

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify the changes. Provide instructions so we can reproduce. Please also list any relevant details to your test configuration.

  • This can only be tested once merged, so no testing has been done, but a check has been done by me as a review

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that provde my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
# Description Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. - Update drone pipelines to use resync > **NOTE:** This requires a new repository secret - `ssh_key` > **NOTE:** This requires moving the cards directory into the new appdata folder #56 ## Type of change Please delete options that are not relevant. - [x] New feature (non-breaking change which adds functionality) # How Has This Been Tested? Please describe the tests that you ran to verify the changes. Provide instructions so we can reproduce. Please also list any relevant details to your test configuration. - This can only be tested once merged, so no testing has been done, but a check has been done by me as a review # Checklist - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that provde my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules
Vylpes added 1 commit 2023-12-21 16:28:55 +00:00
Vylpes added 1 commit 2023-12-21 16:29:18 +00:00
Update script
Some checks are pending
continuous-integration/drone/push Build is running
Details
09bf821be9
Vylpes requested review from VylpesTester 2023-12-21 16:30:13 +00:00
Vylpes added the
type
story
 label 2023-12-21 16:30:16 +00:00
VylpesTester was assigned by Vylpes 2023-12-21 16:30:19 +00:00
VylpesTester requested changes 2023-12-22 14:43:26 +00:00
.drone.yml
@ -9,0 +14,4 @@
commands:
- npm test
- name: deploy to prod
image: drillster/drone-rsync
VylpesTester commented 2023-12-22 14:43:19 +00:00
Member
Copy link

This is good and should be how we want it, but maybe we should also move the cards folder externally as well

This is good and should be how we want it, but maybe we should also move the cards folder externally as well
Vylpes marked this conversation as resolved
VylpesTester added spent time 2023-12-22 14:43:32 +00:00
1 minute
Vylpes added 1 commit 2023-12-26 14:56:55 +00:00
Update card metadata logic so that the card directory can be put anywhere
All checks were successful
continuous-integration/drone/push Build is passing
Details
44b423f889
Vylpes added 1 commit 2023-12-26 14:58:14 +00:00
Merge branch 'develop' into feature/56-drone-rsync
All checks were successful
continuous-integration/drone/push Build is passing
Details
190d014813
Vylpes requested review from VylpesTester 2023-12-26 14:58:41 +00:00
VylpesTester approved these changes 2023-12-29 19:50:54 +00:00
VylpesTester added spent time 2023-12-29 19:51:01 +00:00
1 minute
Vylpes merged commit 1ee7bb8630 into develop 2023-12-29 19:52:00 +00:00
Vylpes deleted branch feature/56-drone-rsync 2023-12-29 19:52:00 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
VylpesTester
Labels
Clear labels   
blocked

   
duplicate

   
needs criteria

   
needs estimate

   
needs tests

   
question

   
requires documentation
  
type
admin

  
type
alert

  
type
bug

  
type
change

  
type
defect

  
type
dependencies

  
type
epic

  
type
spike

  
type
story

  
type
subtask

  
won't fix
No labels
blocked
duplicate
needs criteria
needs estimate
needs tests
question
requires documentation
type
admin
type
alert
type
bug
type
change
type
defect
type
dependencies
type
epic
type
spike
type
story
type
subtask
won't fix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
VylpesTester
2 participants
Notifications
Total time spent: 2 minutes
VylpesTester
2 minutes
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: External/card-drop#121
No description provided.
Delete branch "feature/56-drone-rsync"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?