RabbitLabs/vylbot-core
RabbitLabs/vylbot-core
Archived
4
0
Fork 0
Code Issues 33 Pull requests 3 Projects Releases 7 Wiki Activity

Tests and CI #44

Merged
Vylpes merged 17 commits from feature/tests into develop 2021-08-21 16:00:28 +01:00
Conversation 0 Commits 17 Files changed 16 +3810 -55
Vylpes commented 2021-08-20 16:07:48 +01:00 (Migrated from github.com)
Copy link
  • Add Tests
  • Add Linting
  • Add CI Workflows
- Add Tests - Add Linting - Add CI Workflows
VylpesTester (Migrated from github.com) requested changes 2021-08-21 15:12:02 +01:00
package.json
VylpesTester (Migrated from github.com) commented 2021-08-21 15:04:47 +01:00

I don't think this is used anymore

I don't think this is used anymore
VylpesTester (Migrated from github.com) commented 2021-08-21 15:05:17 +01:00

I don't think this is used anymore

I don't think this is used anymore
tests/__mocks/commands/name.ts
VylpesTester (Migrated from github.com) commented 2021-08-21 15:07:46 +01:00

This should probably be renamed, such as "normal", to indicate its the normal command mock, without anything changed

This should probably be renamed, such as "normal", to indicate its the normal command mock, without anything changed
tests/__mocks/commands/noCategory.ts
VylpesTester (Migrated from github.com) commented 2021-08-21 15:06:40 +01:00

Empty line

Empty line
tests/__mocks/events/name.ts
VylpesTester (Migrated from github.com) commented 2021-08-21 15:09:06 +01:00

Maybe rename this event to "normal", to indicate its the "normal" event mock without anything changed.

Maybe rename this event to "normal", to indicate its the "normal" event mock without anything changed.
tests/client/client.test.ts
VylpesTester (Migrated from github.com) commented 2021-08-21 15:10:11 +01:00

Should these be put into a describe group?

Should these be put into a describe group?
VylpesTester (Migrated from github.com) commented 2021-08-21 15:10:21 +01:00

This would apply to all other tests also

This would apply to all other tests also
VylpesTester (Migrated from github.com) approved these changes 2021-08-21 16:00:11 +01:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
VylpesTester
Labels
Clear labels   
admin

   
bug

Something isn't working

  
dependencies

Pull requests that update a dependency file

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
spike

   
wontfix

This will not be worked on

  
blocked

   
duplicate

   
needs criteria

   
needs estimate

   
question
  
type
admin

  
type
alert

  
type
bug

  
type
defect

  
type
dependencies

  
type
design

  
type
documentation

  
type
epic

  
type
incident

  
type
investigation

  
type
spike

  
type
story

  
won't fix
No labels
admin
bug
dependencies
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
spike
wontfix
blocked
duplicate
needs criteria
needs estimate
question
type
admin
type
alert
type
bug
type
defect
type
dependencies
type
design
type
documentation
type
epic
type
incident
type
investigation
type
spike
type
story
won't fix
Milestone
Clear milestone
No items
No milestone
2.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: RabbitLabs/vylbot-core#44
No description provided.
Delete branch "feature/tests"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?