RSS Feed lastGuid rotation handling (#584) #590

Merged

Vylpes merged 2 commits from cursor/584-rss-feed-lastguid-rotation into feature/epic-528-rss-feeds

2026-10-12 12:17:15 +01:00

Smithy-bot commented

2026-10-12 12:04:00 +01:00

Member

Summary

Stops RssFeedHelper.GetNewItems from treating every feed item as new when the stored lastGuid has rotated off the feed (retention/expiry).

When lastGuid is set but not found, at most 10 newest items are returned (oldest-first). The cap is an optional third argument so timer/commands can reuse it. First-poll behaviour (lastGuid missing/empty → []) is unchanged.

Changes

src/helpers/RssFeedHelper.ts — detect missing lastGuid after scan; apply configurable cap (default 10)
tests/helpers/RssFeedHelper.test.ts — cover default cap overflow, sub-cap feeds, custom cap; keep match/empty cases

Verification

yarn build PASS
yarn test PASS (5 suites / 72 tests)

Ticket: #584

Base is feature/epic-528-rss-feeds (same as #583 / #530) because RssFeedHelper lives on the epic branch, not yet on release/3.4.0.

## Summary Stops `RssFeedHelper.GetNewItems` from treating every feed item as new when the stored `lastGuid` has rotated off the feed (retention/expiry). When `lastGuid` is set but not found, at most **10** newest items are returned (oldest-first). The cap is an optional third argument so timer/commands can reuse it. First-poll behaviour (`lastGuid` missing/empty → `[]`) is unchanged. ## Changes - `src/helpers/RssFeedHelper.ts` — detect missing `lastGuid` after scan; apply configurable cap (default 10) - `tests/helpers/RssFeedHelper.test.ts` — cover default cap overflow, sub-cap feeds, custom cap; keep match/empty cases ## Verification - `yarn build` PASS - `yarn test` PASS (5 suites / 72 tests) Ticket: #584 Base is `feature/epic-528-rss-feeds` (same as #583 / #530) because `RssFeedHelper` lives on the epic branch, not yet on `release/3.4.0`.

Smithy-bot added 2 commits

2026-10-12 12:04:00 +01:00

#584 Cap GetNewItems when lastGuid has rotated off the feed 8a60cdf22d