RabbitLabs/vylbot-app

Watch

Fork 0

Add cursor/* branches to test workflow #559

New issue

Open

opened 2026-08-29 15:17:51 +01:00 by Vylpes · 2 comments

Vylpes commented

2026-08-29 15:17:51 +01:00

Owner

Epic:
Story Points:

No description

Acceptance Criteria

No acceptance criteria

Subtasks

No subtasks

Notes

No notes

Epic: \ Story Points: --- *No description* ## Acceptance Criteria *No acceptance criteria* ## Subtasks *No subtasks* ## Notes *No notes*

Vylpes added this to the 3.6.0 milestone

2026-08-29 15:17:51 +01:00

Vylpes added the

labels

2026-08-29 15:17:51 +01:00

Smithy-bot was assigned by Vylpes

2026-08-29 15:17:59 +01:00

Smithy-bot commented

2026-08-29 16:24:58 +01:00

Member

Blocked — I can't pick a base branch for this work.

This issue is in milestone 3.6.0, and the convention in this repo is that work for milestone X.Y.Z is branched from and merged into release/X.Y.Z (e.g. #545, #543, #542 target release/3.5.0; #539 targets release/3.4.0). There is no release/3.6.0 branch yet — the only release branches are:

release/3.4.0
release/3.5.0

I don't want to guess: basing a cursor/* branch on release/3.5.0 would ship this change in 3.5.0 rather than the 3.6.0 milestone you assigned it to, and cutting a new protected release/* branch is release management rather than something I should do on my own.

Unblock by either:

Cutting release/3.6.0, or
Re-assigning this issue to the 3.5.0 milestone if you'd rather it went out sooner.

Either way, remove blocked and I'll pick it up on the next run.

For reference, the change itself is small — .forgejo/workflows/test.yml currently triggers on:

on:
  push:
    branches:
      - feature/*
      - renovate/*

and needs cursor/* adding to that list so bot branches get built and tested. Worth noting the acceptance criteria are empty on this issue; I've assumed the intent is just the push-trigger branch list, so let me know if you also want cursor/* covered anywhere else.

Blocked — I can't pick a base branch for this work. This issue is in milestone **3.6.0**, and the convention in this repo is that work for milestone `X.Y.Z` is branched from and merged into `release/X.Y.Z` (e.g. #545, #543, #542 target `release/3.5.0`; #539 targets `release/3.4.0`). There is no `release/3.6.0` branch yet — the only release branches are: - `release/3.4.0` - `release/3.5.0` I don't want to guess: basing a `cursor/*` branch on `release/3.5.0` would ship this change in 3.5.0 rather than the 3.6.0 milestone you assigned it to, and cutting a new protected `release/*` branch is release management rather than something I should do on my own. Unblock by either: 1. Cutting `release/3.6.0`, or 2. Re-assigning this issue to the `3.5.0` milestone if you'd rather it went out sooner. Either way, remove `blocked` and I'll pick it up on the next run. For reference, the change itself is small — `.forgejo/workflows/test.yml` currently triggers on: ```yaml on: push: branches: - feature/* - renovate/* ``` and needs `cursor/*` adding to that list so bot branches get built and tested. Worth noting the acceptance criteria are empty on this issue; I've assumed the intent is just the push-trigger branch list, so let me know if you also want `cursor/*` covered anywhere else.

Smithy-bot added the

blocked

label

2026-08-29 16:25:02 +01:00

Vylpes modified the milestone from 3.6.0 to 3.5.0

2026-08-29 16:27:07 +01:00

Vylpes removed the

blocked

label

2026-08-29 16:27:14 +01:00

Smithy-bot added

and removed

labels

2026-08-29 17:18:12 +01:00

Smithy-bot referenced this issue from a commit

2026-08-29 17:18:35 +01:00

Add cursor/* branches to test workflow triggers (#559)

Smithy-bot referenced this issue from a pull request that will close it,

2026-08-29 17:19:21 +01:00

Add cursor/* branches to test workflow (#559) #560

Smithy-bot added

and removed

labels

2026-08-29 17:19:44 +01:00

Smithy-bot commented

2026-08-29 17:19:54 +01:00

Member

Unblocked — thanks for moving this to milestone 3.5.0, that gave me release/3.5.0 as a base. Picked it up and it's now ready for your approval.

PR: #560 (cursor/559-test-workflow-cursor-branches → release/3.5.0)

The change is the single line I described earlier: cursor/* added to on.push.branches in .forgejo/workflows/test.yml, so the list is now cursor/*, feature/*, renovate/*.

Self-checks (full detail in the PR comment): diff is one added line and nothing else, the YAML still parses to the expected trigger, and yarn install --frozen-lockfile / yarn build / yarn test all pass on the branch. I also confirmed a cursor/* push can only hit the Test workflow — stage.yml and production.yml trigger on release branches and tags respectively, so there's no risk of a bot branch deploying anywhere.

I've left .drone.yml alone even though it carries the same branch list, since it's the legacy Drone config rather than active CI — shout if you'd rather it stayed in sync.

Moved to step/review. I won't approve my own PR, so it's over to you.

Unblocked — thanks for moving this to milestone **3.5.0**, that gave me `release/3.5.0` as a base. Picked it up and it's now ready for your approval. **PR:** #560 (`cursor/559-test-workflow-cursor-branches` → `release/3.5.0`) The change is the single line I described earlier: `cursor/*` added to `on.push.branches` in `.forgejo/workflows/test.yml`, so the list is now `cursor/*`, `feature/*`, `renovate/*`. Self-checks (full detail in the PR comment): diff is one added line and nothing else, the YAML still parses to the expected trigger, and `yarn install --frozen-lockfile` / `yarn build` / `yarn test` all pass on the branch. I also confirmed a `cursor/*` push can only hit the Test workflow — `stage.yml` and `production.yml` trigger on release branches and tags respectively, so there's no risk of a bot branch deploying anywhere. I've left `.drone.yml` alone even though it carries the same branch list, since it's the legacy Drone config rather than active CI — shout if you'd rather it stayed in sync. Moved to `step/review`. I won't approve my own PR, so it's over to you.