RabbitLabs/vylbot-app
RabbitLabs/vylbot-app
4
0
Fork 0
Code Issues 89 Pull requests 6 Actions Packages Projects 1 Releases 21 Wiki Activity

Add list moons command #449

Merged
Vylpes merged 15 commits from feature/195-list-moons into develop 2024-08-17 16:47:14 +01:00
Conversation 0 Commits 15 Files changed 10 +235 -3
Vylpes commented 2024-07-06 17:48:26 +01:00
Owner
Copy link
  • Add concept of moons to the database
  • Add the list moons command to view a user's moons
  • This command is paginated using buttons

#195

- Add concept of moons to the database - Add the list moons command to view a user's moons - This command is paginated using buttons #195
Vylpes added 6 commits 2024-07-06 17:48:27 +01:00
WIP: Create base moon command
All checks were successful
Test / build (push) Successful in 8s
Details
7b620dfd90
Create lobby command
All checks were successful
Test / build (push) Successful in 5s
Details
690b63470a
Add pagination buttons
All checks were successful
Test / build (push) Successful in 6s
Details
673b258fa9
Vylpes requested review from VylpesTester 2024-07-06 17:48:31 +01:00
VylpesTester was assigned by Vylpes 2024-07-06 17:48:35 +01:00
Vylpes added the
type
story
 label 2024-07-06 17:48:41 +01:00
VylpesTester requested changes 2024-07-06 19:08:41 +01:00
Dismissed
database/3.3.0/1719856023429-CreateMoon/Up/01-Moon.sql
@ -0,0 +1,9 @@
CREATE TABLE `moon` (
VylpesTester commented 2024-07-06 19:05:20 +01:00
Member
Copy link

Need to specify the primary key

Need to specify the primary key
Vylpes commented 2024-08-06 18:33:50 +01:00
Author
Owner
Copy link

I haven't for previous migrations, is it worth still doing?

I haven't for previous migrations, is it worth still doing?
VylpesTester marked this conversation as resolved
src/constants/MoonValues.ts Outdated
@ -0,0 +1,3 @@
export default class MoonValues {
VylpesTester commented 2024-07-06 19:06:55 +01:00
Member
Copy link

Maybe call this MoonConstants? I think that would make more sense

Maybe call this `MoonConstants`? I think that would make more sense
Vylpes marked this conversation as resolved
src/database/entities/Moon.ts Outdated
@ -0,0 +31,4 @@
}
public static async FetchPaginatedMoonsByUserId(userId: string, page: number): Promise<[ Moon[], number ]> {
const rangeStart = page * MoonValues.ListPageLength;
VylpesTester commented 2024-07-06 19:08:13 +01:00
Member
Copy link

ListPageLength could just be a parameter tbh

`ListPageLength` could just be a parameter tbh
Vylpes commented 2024-08-06 18:37:00 +01:00
Author
Owner
Copy link

Or we make it a global page length, affecting all future pages?

Or we make it a global page length, affecting all future pages?
VylpesTester commented 2024-08-12 16:10:48 +01:00
Member
Copy link

I think just make it a parameter, the issue with that would be adjusting it for 1 and having unintended changes on other pages

I think just make it a parameter, the issue with that would be adjusting it for 1 and having unintended changes on other pages
Vylpes marked this conversation as resolved
Vylpes started working 2024-08-06 18:30:19 +01:00
Vylpes canceled time tracking 2024-08-06 18:30:22 +01:00
Vylpes added 2 commits 2024-08-06 18:37:32 +01:00
Rename MoonValues to MoonConstants
All checks were successful
Test / build (push) Successful in 6s
Details
084b8aea79
Vylpes requested review from VylpesTester 2024-08-07 18:02:34 +01:00
VylpesTester requested changes 2024-08-12 16:11:02 +01:00
Dismissed
VylpesTester left a comment
Member
Copy link

See comments

See comments
Vylpes added 1 commit 2024-08-12 16:31:56 +01:00
Remove need for MoonConstants file
All checks were successful
Test / build (push) Successful in 6s
Details
4ef8f0edd0
Vylpes added 2 commits 2024-08-14 18:21:16 +01:00
Add moon button event
All checks were successful
Test / build (push) Successful in 5s
Details
dc3cb93653
Vylpes added 4 commits 2024-08-15 19:31:43 +01:00
Add page number
All checks were successful
Test / build (push) Successful in 6s
Details
e7527abdf9
Vylpes requested review from VylpesTester 2024-08-15 19:32:11 +01:00
VylpesTester approved these changes 2024-08-17 16:46:55 +01:00
Vylpes merged commit e2ec042fcd into develop 2024-08-17 16:47:14 +01:00
Vylpes deleted branch feature/195-list-moons 2024-08-17 16:47:14 +01:00
Vylpes referenced this pull request from a commit 2024-08-17 16:47:14 +01:00
Add list moons command (#449)
Sign in to join this conversation.
Reviewers
No reviewers
VylpesTester
Labels
Clear labels   
blocked

   
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
needs criteria

   
needs estimate

   
needs testing

   
question

Further information is requested

  
type
admin

  
type
bug
Something isn't working

  
type
defect
A task that has fallen out of testing

  
type
dependencies
Pull requests that update a dependency file

  
type
documentation
Improvements or additions to documentation

  
type
epic

  
type
incident

  
type
investigation

  
type
spike

  
type
story

  
type
subtask

  
wontfix

This will not be worked on

  
blocked

   
duplicate

   
needs criteria

   
needs estimate

   
question
  
type
admin

  
type
alert

  
type
bug

  
type
defect

  
type
dependencies

  
type
design

  
type
documentation

  
type
epic

  
type
incident

  
type
investigation

  
type
spike

  
type
story

  
won't fix
No labels
blocked
duplicate
enhancement
good first issue
help wanted
invalid
needs criteria
needs estimate
needs testing
question
type
admin
type
bug
type
defect
type
dependencies
type
documentation
type
epic
type
incident
type
investigation
type
spike
type
story
type
subtask
wontfix
blocked
duplicate
needs criteria
needs estimate
question
type
admin
type
alert
type
bug
type
defect
type
dependencies
type
design
type
documentation
type
epic
type
incident
type
investigation
type
spike
type
story
won't fix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
VylpesTester
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: RabbitLabs/vylbot-app#449
No description provided.
Delete branch "feature/195-list-moons"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?