RabbitLabs/vylbot-app
RabbitLabs/vylbot-app
5
0
Fork 0
Code Issues 90 Pull requests 4 Projects 1 Releases 22 Packages Wiki Activity Actions

Improve the way events are implemented #103

New issue
Closed
opened 2022-01-30 15:25:21 +00:00 by Vylpes · 2 comments
Vylpes commented 2022-01-30 15:25:21 +00:00 (Migrated from github.com)
Copy link

Currently events aren't that efficient, what they are doing right now having an event class run all methods whether they are implemented or not.

This should be changed so that during event registration it only adds the methods which are being used.

Subtasks

  • Improve way events are implemented
  • #205
Currently events aren't that efficient, what they are doing right now having an event class run all methods whether they are implemented or not. This should be changed so that during event registration it only adds the methods which are being used. ## Subtasks - [x] Improve way events are implemented - [x] #205
Vylpes commented 2022-10-16 15:07:06 +01:00 (Migrated from github.com)
Copy link

This has failed testing:

  • Event embeds don't have the user's avatar in the thumbnail
This has failed testing: - Event embeds don't have the user's avatar in the thumbnail
Vylpes added this to the 3.1 milestone 2022-11-10 20:06:33 +00:00
Vylpes added this to the 3.1 Sprint 5 project 2022-11-10 20:06:37 +00:00
VylpesTester commented 2022-11-13 09:40:17 +00:00
Member
Copy link

This has passed testing

This has passed testing
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
renovate/node-22.x-lockfile
renovate/appleboy-ssh-action-1.x
feature/300-moon-set
develop
hotfix/3.2.4
renovate/minimatch-10.x
v3.2.3
v3.2.2
v3.2.1
v3.2.0
v3.1.3
v3.1.2
v3.1.1
v3.1.0
v3.0.7
v3.0.6
v3.0.5
v3.1-alpha1
v3.0.4
v3.0.3
v3.0.2
v3.0.1
v3.0
v3.0-rc2
v3.0-rc1
v3.0-beta2
v3.0-beta1
v2.1.3
Labels
Clear labels   
blocked

   
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
needs criteria

   
needs estimate

   
needs testing

   
question

Further information is requested

  
type
admin

  
type
bug
Something isn't working

  
type
change

  
type
defect
A task that has fallen out of testing

  
type
dependencies
Pull requests that update a dependency file

  
type
documentation
Improvements or additions to documentation

  
type
epic

  
type
incident

  
type
investigation

  
type
spike

  
type
story

  
type
subtask

  
wontfix

This will not be worked on

  
blocked

   
duplicate

   
needs criteria

   
needs designs

   
needs estimate

   
needs testing

   
question
  
type
admin

  
type
alert

  
type
bug

  
type
defect

  
type
dependencies

  
type
design

  
type
documentation

  
type
epic

  
type
incident

  
type
investigation

  
type
spike

  
type
story

  
won't fix
No labels
blocked
duplicate
enhancement
good first issue
help wanted
invalid
needs criteria
needs estimate
needs testing
question
type
admin
type
bug
type
change
type
defect
type
dependencies
type
documentation
type
epic
type
incident
type
investigation
type
spike
type
story
type
subtask
wontfix
blocked
duplicate
needs criteria
needs designs
needs estimate
needs testing
question
type
admin
type
alert
type
bug
type
defect
type
dependencies
type
design
type
documentation
type
epic
type
incident
type
investigation
type
spike
type
story
won't fix
Milestone
Clear milestone
No items
No milestone
3.1
Projects
Clear projects
No items
No project
3.1 Sprint 5
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: RabbitLabs/vylbot-app#103
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?