Merge branch 'develop' into feature/258-fix-tests

src/commands/bunny.ts

@@ -15,6 +15,8 @@ export default class Bunny extends Command {
     public override async execute(interaction: CommandInteraction) {
         if (!interaction.isChatInputCommand()) return;
 
+        await interaction.deferReply();
+
         const subreddits = [
             'rabbits',
             'bunnieswithhats',
@@ -37,9 +39,9 @@ export default class Bunny extends Command {
                 .setURL(`https://reddit.com${result.Result!.Permalink}`)
                 .setFooter({ text: `r/${selectedSubreddit} · ${result.Result!.Ups} upvotes`});
 
-            await interaction.reply({ embeds: [ embed ]});
+            await interaction.editReply({ embeds: [ embed ]});
         } else {
-            await interaction.reply("There was an error running this command.");
+            await interaction.editReply("There was an error running this command.");
         }
     }
 }

src/commands/unmute.ts

@@ -7,7 +7,7 @@ export default class Unmute extends Command {
     constructor() {
         super();
 
-        super.CommandBuilder = new SlashCommandBuilder()
+        this.CommandBuilder = new SlashCommandBuilder()
             .setName("unmute")
             .setDescription("(DEPRECATED) Unmute a member in the server with an optional reason")
             .setDefaultMemberPermissions(PermissionsBitField.Flags.ModerateMembers)

src/events/MemberEvents/GuildMemberUpdate.ts

@@ -3,7 +3,9 @@ import NicknameChanged from "./GuildMemberUpdate/NicknameChanged";
 import CacheHelper from "../../helpers/CacheHelper";
 
 export default async function GuildMemberUpdate(oldMember: GuildMember, newMember: GuildMember) {
-    await CacheHelper.UpdateServerCache(newMember.guild);
+    const updatedFromCache = await CacheHelper.UpdateServerCache(newMember.guild);
+
+    if (updatedFromCache) return;
 
     if (oldMember.nickname !== newMember.nickname) { // Nickname change
         await NicknameChanged(oldMember, newMember);

src/helpers/CacheHelper.ts

@@ -2,10 +2,10 @@ import { Guild } from "discord.js";
 import Server from "../database/entities/Server";
 
 export default class CacheHelper {
-    public static async UpdateServerCache(guild: Guild) {
+    public static async UpdateServerCache(guild: Guild): Promise<boolean> {
         const cacheInterval = process.env.CACHE_INTERVAL;
 
-        if (!cacheInterval) return;
+        if (!cacheInterval) return false;
 
         let server = await Server.FetchOneById(Server, guild.id);
 
@@ -14,9 +14,15 @@ export default class CacheHelper {
             await server.Save(Server, server);
 
             await CacheHelper.UpdateCache(guild);
-        } else if (server.LastCached.getTime() + Number(cacheInterval) < Date.now()) {
+
+            return true;
+        } else if (server.LastCached.getTime() + Number(cacheInterval) > Date.now()) {
             await CacheHelper.UpdateCache(guild);
+
+            return true;
         }
+
+        return false;
     }
 
     private static async UpdateCache(guild: Guild) {