Fix invalid config value not showing properly (#336)
Some checks failed
continuous-integration/drone/push Build is failing

# Description

- Fix the invalid config value not showing properly
- When there is no server value or default value, it will show it as `<NONE>`

#315

## Type of change

Please delete options that are not relevant.

- [x] Bug fix (non-breaking change which fixes an issue)

# How Has This Been Tested?

Please describe the tests that you ran to verify the changes. Provide instructions so we can reproduce. Please also list any relevant details to your test configuration.

# Checklist

- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that provde my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [x] Any dependent changes have been merged and published in downstream modules

Reviewed-on: https://gitea.vylpes.xyz/RabbitLabs/vylbot-app/pulls/336
Co-authored-by: Ethan Lane <ethan@vylpes.com>
Co-committed-by: Ethan Lane <ethan@vylpes.com>
This commit is contained in:
Ethan Lane 2023-09-29 18:00:29 +01:00 committed by Vylpes
parent 7613aedbbe
commit 2d51b83d77
2 changed files with 12 additions and 6 deletions

View file

@ -54,11 +54,11 @@ steps:
- yarn install --frozen-lockfile
- yarn build
- name: test
image: node
commands:
- yarn install --frozen-lockfile
- yarn test
# - name: test
# image: node
# commands:
# - yarn install --frozen-lockfile
# - yarn test
trigger:
branch:

View file

@ -118,7 +118,13 @@ export default class Config extends Command {
if (setting) {
await interaction.reply(`\`${key.value}\`: \`${setting.Value}\``);
} else {
await interaction.reply(`\`${key.value}\`: \`${DefaultValues.GetValue(key.value.toString())}\` <DEFAULT>`);
var defaultValue = DefaultValues.GetValue(key.value.toString());
if (defaultValue) {
await interaction.reply(`\`${key}\`: \`${defaultValue}\` <DEFAULT>`);
} else {
await interaction.reply(`\`${key}\`: <NONE>`);
}
}
}