Ethan Lane
04ed2d7414
All checks were successful
continuous-integration/drone/push Build is passing
# Description Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. - Fix the fetch not failing gracefully using the new error handler #91 ## Type of change Please delete options that are not relevant. - [x] Bug fix (non-breaking change which fixes an issue) # How Has This Been Tested? Please describe the tests that you ran to verify the changes. Provide instructions so we can reproduce. Please also list any relevant details to your test configuration. - Updated the tests to be more accurate to the fetching package by using a promise reject - Tested the code by turning my wifi off and ensuring the output is the new error handler # Checklist - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that provde my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules Reviewed-on: https://gitea.vylpes.xyz/RabbitLabs/random-bunny/pulls/100 Co-authored-by: Ethan Lane <ethan@vylpes.com> Co-committed-by: Ethan Lane <ethan@vylpes.com>
193 lines
No EOL
7.3 KiB
TypeScript
193 lines
No EOL
7.3 KiB
TypeScript
import { ErrorCode } from "../src/constants/ErrorCode";
|
||
import ErrorMessages from "../src/constants/ErrorMessages";
|
||
import randomBunny from "../src/index";
|
||
import fetch, { CancelableRequest } from "got-cjs";
|
||
|
||
jest.mock('got-cjs');
|
||
const fetchMock = jest.mocked(fetch);
|
||
|
||
describe('randomBunny', () => {
|
||
test('GIVEN subreddit AND sortBy is supplied, EXPECT successful result', async() => {
|
||
fetchMock.mockResolvedValue({
|
||
body: JSON.stringify({
|
||
data: {
|
||
children: [
|
||
{
|
||
data: {
|
||
archived: false,
|
||
downs: 0,
|
||
hidden: false,
|
||
permalink: '/r/Rabbits/comments/12pa5te/someone_told_pickles_its_monday_internal_fury/',
|
||
subreddit: 'Rabbits',
|
||
subreddit_subscribers: 298713,
|
||
title: 'Someone told pickles it’s Monday… *internal fury*',
|
||
ups: 1208,
|
||
url: 'https://i.redd.it/cr8xudsnkgua1.jpg',
|
||
},
|
||
},
|
||
],
|
||
}
|
||
}),
|
||
});
|
||
|
||
const result = await randomBunny('rabbits', 'new');
|
||
|
||
expect(result.IsSuccess).toBeTruthy();
|
||
expect(result.Result).toBeDefined();
|
||
expect(result.Error).toBeUndefined();
|
||
|
||
expect(fetchMock).toBeCalledWith('https://reddit.com/r/rabbits/new.json');
|
||
});
|
||
|
||
test('GIVEN sortBy is NOT supplied, expect it to default to hot', async () => {
|
||
fetchMock.mockResolvedValue({
|
||
body: JSON.stringify({
|
||
data: {
|
||
children: [
|
||
{
|
||
data: {
|
||
archived: false,
|
||
downs: 0,
|
||
hidden: false,
|
||
permalink: '/r/Rabbits/comments/12pa5te/someone_told_pickles_its_monday_internal_fury/',
|
||
subreddit: 'Rabbits',
|
||
subreddit_subscribers: 298713,
|
||
title: 'Someone told pickles it’s Monday… *internal fury*',
|
||
ups: 1208,
|
||
url: 'https://i.redd.it/cr8xudsnkgua1.jpg',
|
||
},
|
||
},
|
||
],
|
||
}
|
||
}),
|
||
});
|
||
|
||
const result = await randomBunny('rabbits');
|
||
|
||
expect(result.IsSuccess).toBeTruthy();
|
||
expect(result.Result).toBeDefined();
|
||
expect(result.Error).toBeUndefined();
|
||
|
||
expect(fetchMock).toBeCalledWith('https://reddit.com/r/rabbits/hot.json');
|
||
});
|
||
|
||
test('GIVEN sortBy is NOT valid, expect it to default to hot', async () => {
|
||
fetchMock.mockResolvedValue({
|
||
body: JSON.stringify({
|
||
data: {
|
||
children: [
|
||
{
|
||
data: {
|
||
archived: false,
|
||
downs: 0,
|
||
hidden: false,
|
||
permalink: '/r/Rabbits/comments/12pa5te/someone_told_pickles_its_monday_internal_fury/',
|
||
subreddit: 'Rabbits',
|
||
subreddit_subscribers: 298713,
|
||
title: 'Someone told pickles it’s Monday… *internal fury*',
|
||
ups: 1208,
|
||
url: 'https://i.redd.it/cr8xudsnkgua1.jpg',
|
||
},
|
||
},
|
||
],
|
||
}
|
||
}),
|
||
});
|
||
|
||
const result = await randomBunny('rabbits', 'invalid');
|
||
|
||
expect(result.IsSuccess).toBeTruthy();
|
||
expect(result.Result).toBeDefined();
|
||
expect(result.Error).toBeUndefined();
|
||
|
||
expect(fetchMock).toBeCalledWith('https://reddit.com/r/rabbits/hot.json');
|
||
});
|
||
|
||
test('GIVEN the fetch fails, EXPECT failure result', async () => {
|
||
fetchMock.mockRejectedValue('Test Reason')
|
||
|
||
const result = await randomBunny('rabbits', 'new');
|
||
|
||
expect(result.IsSuccess).toBeFalsy();
|
||
expect(result.Result).toBeUndefined();
|
||
expect(result.Error).toBeDefined();
|
||
|
||
expect(result.Error!.Code).toBe(ErrorCode.FailedToFetchReddit);
|
||
expect(result.Error!.Message).toBe(ErrorMessages.FailedToFetchReddit);
|
||
|
||
expect(fetchMock).toBeCalledWith('https://reddit.com/r/rabbits/new.json');
|
||
});
|
||
|
||
test('GIVEN the result is NOT valid JSON, EXPECT failure result', async () => {
|
||
fetchMock.mockResolvedValue({
|
||
body: JSON.stringify(null),
|
||
});
|
||
|
||
const result = await randomBunny('rabbits', 'new');
|
||
|
||
expect(result.IsSuccess).toBeFalsy();
|
||
expect(result.Result).toBeUndefined();
|
||
expect(result.Error).toBeDefined();
|
||
|
||
expect(result.Error!.Code).toBe(ErrorCode.UnableToParseJSON);
|
||
expect(result.Error!.Message).toBe(ErrorMessages.UnableToParseJSON);
|
||
|
||
expect(fetchMock).toBeCalledWith('https://reddit.com/r/rabbits/new.json');
|
||
});
|
||
|
||
test('GIVEN randomSelect does NOT find a response, EXPECT failure result', async () => {
|
||
fetchMock.mockResolvedValue({
|
||
body: JSON.stringify({
|
||
data: {
|
||
children: [],
|
||
}
|
||
}),
|
||
});
|
||
|
||
const result = await randomBunny('rabbits', 'new');
|
||
|
||
expect(result.IsSuccess).toBeFalsy();
|
||
expect(result.Result).toBeUndefined();
|
||
expect(result.Error).toBeDefined();
|
||
|
||
expect(result.Error!.Code).toBe(ErrorCode.NoImageResultsFound);
|
||
expect(result.Error!.Message).toBe(ErrorMessages.NoImageResultsFound);
|
||
|
||
expect(fetchMock).toBeCalledWith('https://reddit.com/r/rabbits/new.json');
|
||
});
|
||
|
||
test('GIVEN randomSelect does NOT find a valid response, EXPECT failure result', async () => {
|
||
fetchMock.mockResolvedValue({
|
||
body: JSON.stringify({
|
||
data: {
|
||
children: [
|
||
{
|
||
data: {
|
||
archived: false,
|
||
downs: 0,
|
||
hidden: false,
|
||
permalink: '/r/Rabbits/comments/12pa5te/someone_told_pickles_its_monday_internal_fury/',
|
||
subreddit: 'Rabbits',
|
||
subreddit_subscribers: 298713,
|
||
title: 'Someone told pickles it’s Monday… *internal fury*',
|
||
ups: 1208,
|
||
url: 'https://i.redd.it/cr8xudsnkgua1.webp',
|
||
},
|
||
},
|
||
],
|
||
}
|
||
}),
|
||
});
|
||
|
||
const result = await randomBunny('rabbits', 'new');
|
||
|
||
expect(result.IsSuccess).toBeFalsy();
|
||
expect(result.Result).toBeUndefined();
|
||
expect(result.Error).toBeDefined();
|
||
|
||
expect(result.Error!.Code).toBe(ErrorCode.NoImageResultsFound);
|
||
expect(result.Error!.Message).toBe(ErrorMessages.NoImageResultsFound);
|
||
|
||
expect(fetchMock).toBeCalledWith('https://reddit.com/r/rabbits/new.json');
|
||
});
|
||
}); |