Ethan Lane
2e5f8c3633
# Description Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. - Fix the unit tests "toBeCalledWith" assert being deprecated - Update the "sortBy" variable to be a string literal - Add an output to file option to the CLI - Reorganise the code so there's less repeated code - Update the tests so the CLI logic is tested quicker #138, #76, #80 ## Type of change Please delete options that are not relevant. - [x] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [x] This change requires a documentation update # How Has This Been Tested? Please describe the tests that you ran to verify the changes. Provide instructions so we can reproduce. Please also list any relevant details to your test configuration. # Checklist - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that provde my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules Reviewed-on: #182 Reviewed-by: VylpesTester <tester@vylpes.com> Co-authored-by: Ethan Lane <ethan@vylpes.com> Co-committed-by: Ethan Lane <ethan@vylpes.com>
90 lines
3.1 KiB
TypeScript
90 lines
3.1 KiB
TypeScript
import ImageHelper from "../../src/helpers/imageHelper";
|
|
import fetch from "got-cjs";
|
|
|
|
jest.mock('got-cjs');
|
|
const fetchMock = jest.mocked(fetch);
|
|
|
|
describe("FetchImageFromRedditGallery", () => {
|
|
test("EXPECT image url to be returned", async () => {
|
|
fetchMock.mockResolvedValue({
|
|
body: "<html><body><img src='https://preview.redd.it/image.png' /></body></html>",
|
|
errored: undefined,
|
|
statusCode: 200,
|
|
});
|
|
|
|
const result = await ImageHelper.FetchImageFromRedditGallery("https://redd.it/gallery/image");
|
|
|
|
expect(fetchMock).toHaveBeenCalledTimes(1);
|
|
expect(fetchMock).toHaveBeenCalledWith("https://redd.it/gallery/image");
|
|
|
|
expect(result).toBe("https://preview.redd.it/image.png");
|
|
});
|
|
|
|
test("GIVEN fetch is unable to return data, EXPECT undefined returned", async () => {
|
|
fetchMock.mockResolvedValue(null);
|
|
|
|
const result = await ImageHelper.FetchImageFromRedditGallery("https://redd.it/gallery/image");
|
|
|
|
expect(result).toBeUndefined();
|
|
});
|
|
|
|
test("GIVEN fetch is an error, EXPECT undefined returned", async () => {
|
|
fetchMock.mockResolvedValue({
|
|
body: "<html><body><img src='https://preview.redd.it/image.png' /></body></html>",
|
|
errored: "Error",
|
|
statusCode: 200,
|
|
});
|
|
|
|
const result = await ImageHelper.FetchImageFromRedditGallery("https://redd.it/gallery/image");
|
|
|
|
expect(result).toBeUndefined();
|
|
});
|
|
|
|
test("GIVEN fetch is not status code of 200, EXPECT undefined returned", async () => {
|
|
fetchMock.mockResolvedValue({
|
|
body: "<html><body><img src='https://preview.redd.it/image.png' /></body></html>",
|
|
errored: undefined,
|
|
statusCode: 500,
|
|
});
|
|
|
|
const result = await ImageHelper.FetchImageFromRedditGallery("https://redd.it/gallery/image");
|
|
|
|
expect(result).toBeUndefined();
|
|
});
|
|
|
|
test("GIVEN image tag is not found, EXPECT undefined returned", async () => {
|
|
fetchMock.mockResolvedValue({
|
|
body: "<html><body></body></html>",
|
|
errored: undefined,
|
|
statusCode: 200,
|
|
});
|
|
|
|
const result = await ImageHelper.FetchImageFromRedditGallery("https://redd.it/gallery/image");
|
|
|
|
expect(result).toBeUndefined();
|
|
});
|
|
|
|
test("GIVEN image source attribute is not found, EXPECT undefined returned", async () => {
|
|
fetchMock.mockResolvedValue({
|
|
body: "<html><body><img /></body></html>",
|
|
errored: undefined,
|
|
statusCode: 200,
|
|
});
|
|
|
|
const result = await ImageHelper.FetchImageFromRedditGallery("https://redd.it/gallery/image");
|
|
|
|
expect(result).toBeUndefined();
|
|
});
|
|
|
|
test("GIVEN image source attribute is not found that is a preview.redd.it url, EXPECT undefined returned", async () => {
|
|
fetchMock.mockResolvedValue({
|
|
body: "<html><body><img src='main.png' /></body></html>",
|
|
errored: undefined,
|
|
statusCode: 200,
|
|
});
|
|
|
|
const result = await ImageHelper.FetchImageFromRedditGallery("https://redd.it/gallery/image");
|
|
|
|
expect(result).toBeUndefined();
|
|
});
|
|
}); |