Fix not being able to execute the code via ts-node #122

Merged
VylpesTester merged 2 commits from feature/119-cli-ts-node into develop 2023-12-08 17:07:52 +00:00
Owner

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

  • Removed ts-node
    • Since we can execute the code via unit tests and the command line now, it doesn't make to have this anymore as we can test using a proper CLI
    • This also fixes the issue we have with ts-node, with it not working on the latest node version

#75, #119

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify the changes. Provide instructions so we can reproduce. Please also list any relevant details to your test configuration.

  • This has been tested by running yarn start, and it now runs the cli interface

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that provde my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
# Description Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. - Removed ts-node - Since we can execute the code via unit tests and the command line now, it doesn't make to have this anymore as we can test using a proper CLI - This also fixes the issue we have with ts-node, with it not working on the latest node version #75, #119 ## Type of change Please delete options that are not relevant. - [x] Bug fix (non-breaking change which fixes an issue) # How Has This Been Tested? Please describe the tests that you ran to verify the changes. Provide instructions so we can reproduce. Please also list any relevant details to your test configuration. - This has been tested by running `yarn start`, and it now runs the cli interface # Checklist - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that provde my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules
Vylpes added 2 commits 2023-12-04 17:35:23 +00:00
Make the cli the default interaction
All checks were successful
continuous-integration/drone/push Build is passing
be014e860f
Remove ts-node dependency
All checks were successful
continuous-integration/drone/push Build is passing
75426ad8b7
Vylpes requested review from VylpesTester 2023-12-04 17:35:40 +00:00
Vylpes added the
type
defect
label 2023-12-04 17:35:45 +00:00
VylpesTester was assigned by Vylpes 2023-12-04 17:35:53 +00:00
VylpesTester approved these changes 2023-12-08 17:07:41 +00:00
VylpesTester merged commit a09beba4e4 into develop 2023-12-08 17:07:52 +00:00
VylpesTester deleted branch feature/119-cli-ts-node 2023-12-08 17:07:52 +00:00
VylpesTester added spent time 2023-12-08 17:07:58 +00:00
1 minute
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Total time spent: 1 minute
VylpesTester
1 minute
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: RabbitLabs/random-bunny#122
No description provided.