Add a newline character to the output of a file

- Remove the missed deprecated `toBeCalledWith` function call and replaced with `toHaveBeenCalledWith`
- There should now no longer be any deprecated functions

#138

Reviewed-on: #195
Reviewed-by: VylpesTester <tester@vylpes.com>
Co-authored-by: Ethan Lane <ethan@vylpes.com>
Co-committed-by: Ethan Lane <ethan@vylpes.com>

src/helpers/cliHelper.ts

@@ -9,7 +9,7 @@ export default class CliHelper {
             const output = OutputHelper.GenerateOutput(response, options);
 
             if (options.o) {
-                writeFileSync(options.o, output);
+                writeFileSync(options.o, `${output}\n`);
             } else {
                 console.log(output);
             }

tests/helpers/cliHelper.test.ts

@@ -35,7 +35,7 @@ describe("Endpoint", () => {
             expect(OutputHelper.GenerateOutput).toHaveBeenCalledWith(response, options);
 
             expect(fs.writeFileSync).toHaveBeenCalledTimes(1);
-            expect(fs.writeFileSync).toHaveBeenCalledWith("file.txt", "test output");
+            expect(fs.writeFileSync).toHaveBeenCalledWith("file.txt", "test output\n");
 
             expect(console.log).not.toHaveBeenCalled();
 

tests/index.test.ts

@@ -122,7 +122,7 @@ describe('randomBunny', () => {
         expect(result.Error!.Code).toBe(ErrorCode.NoImageResultsFound);
         expect(result.Error!.Message).toBe(ErrorMessages.NoImageResultsFound);
 
-        expect(fetchMock).toBeCalledWith('https://reddit.com/r/rabbits/new.json?limit=100');
+        expect(fetchMock).toHaveBeenCalledWith('https://reddit.com/r/rabbits/new.json?limit=100');
     });
 
     test('GIVEN randomSelect does NOT find a valid response, EXPECT failure result', async () => {