Add ability to cycle through history in cli with the up/down keys #46

Merged

Vylpes merged 2 commits from feature/24-cycle-session-history into release/0.1.0 2026-10-31 11:53:47 +00:00

Conversation 1 Commits 2 Files changed 8 +454 -29

Vylpes commented 2026-10-31 10:23:26 +00:00

Owner

Copy link

#24

#24

Vylpes added 2 commits 2026-10-31 10:23:26 +00:00

Add ability to cycle through history in cli with the up/down keys 91417b309b

Add invalid expressions to history e4ae58c2f4

Vylpes requested review from Smithy-bot 2026-10-31 10:24:49 +00:00

Smithy-bot was assigned by Vylpes 2026-10-31 10:24:51 +00:00

Vylpes added the

type

story

label 2026-10-31 10:24:56 +00:00

Smithy-bot approved these changes 2026-10-31 11:02:37 +00:00

Smithy-bot left a comment

Copy link

Approved for #24.

Interactive CLI uses rustyline for Up/Down recall with in-session history only (add_history_entry, no persistence file). Inputs are recorded before evaluate so bad expressions can be edited; quit/exit and blank lines are excluded. SessionHistory + integration tests cover recording rules; crate layout change (vyxcalc lib) is consistent. Looks good to merge.

**Approved** for #24. Interactive CLI uses `rustyline` for Up/Down recall with in-session history only (`add_history_entry`, no persistence file). Inputs are recorded before evaluate so bad expressions can be edited; quit/exit and blank lines are excluded. `SessionHistory` + integration tests cover recording rules; crate layout change (`vyxcalc` lib) is consistent. Looks good to merge.

Vylpes merged commit 0a6bde4fb9 into release/0.1.0 2026-10-31 11:53:47 +00:00

Vylpes deleted branch feature/24-cycle-session-history 2026-10-31 11:53:47 +00:00

Vylpes referenced this pull request from a commit 2026-10-31 11:53:48 +00:00

Merge pull request 'Add ability to cycle through history in cli with the up/down keys' (#46) from feature/24-cycle-session-history into release/0.1.0

Smithy-bot referenced this pull request 2026-11-02 11:08:21 +00:00

AS a user, I want to be able to cycle the current session's history #24

Sign in to join this conversation.

Reviewers

No reviewers

Smithy-bot

Labels

Clear labels

  

blocked

  

duplicate

  

high priority

  

needs

approval

  

needs

criteria

  

needs

estimate

  

needs

tests

  

question

  

step

doing

  

step

review

  

step

testing

  

step

todo

  

step

uat

  

type

admin

  

type

alert

  

type

bug

  

type

change

  

type

defect

  

type

dependencies

  

type

development

  

type

documentation

  

type

epic

  

type

idea

  

type

incident

  

type

investigation

  

type

spike

  

type

story

  

type

tests

  

won't fix

No labels

blocked

duplicate

high priority

needs

approval

needs

criteria

needs

estimate

needs

tests

question

step

doing

step

review

step

testing

step

todo

step

uat

type

admin

type

alert

type

bug

type

change

type

defect

type

dependencies

type

development

type

documentation

type

epic

type

idea

type

incident

type

investigation

type

spike

type

story

type

tests

won't fix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

Smithy-bot

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

RabbitLabs/calculator!46

No description provided.