External/card-drop
5
0
Fork 0
Code Issues 39 Pull requests Projects 1 Releases 33 Packages Wiki Activity Actions

Add guards to the drop and reroll commands in case the card fetcher fails #449

Merged
Vylpes merged 3 commits from feature/CD-446 into hotfix/0.9.1 2025-05-24 10:39:34 +01:00
Conversation 0 Commits 3 Files changed 4 +4 -4
2 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 8eb33108f9 - Show all commits

2
src/helpers/DropHelpers/GetCardsHelper.ts
View file

@ -55,7 +55,7 @@ export default class GetCardsHelper {
.find(x => x.cards.includes(card));
if (!series) {
AppLogger.LogWarn("CardDropHelperMetadata/GetRandomCardByRarity", `Series not found for card ${card.id}`);
AppLogger.LogError("CardDropHelperMetadata/GetRandomCardByRarity", `Series not found for card ${card.id}`);
return undefined;
}

6
src/helpers/DropHelpers/GetUnclaimedCardsHelper.ts
View file

@ -42,7 +42,7 @@ export default class GetUnclaimedCardsHelper {
.filter(x => !claimedCards.find(y => y.CardNumber == x.id));
if (!allCards) {
AppLogger.LogWarn("CardDropHelperMetadata/GetRandomCardByRarityUnclaimed", "No cards found to randomise from");
AppLogger.LogError("CardDropHelperMetadata/GetRandomCardByRarityUnclaimed", "No cards found to randomise from");
return undefined;
};
@ -52,7 +52,7 @@ export default class GetUnclaimedCardsHelper {
const card = allCards[randomCardIndex];
if (!card) {
AppLogger.LogWarn("CardDropHelperMetadata/GetRandomCardByRarityUnclaimed", `Card not found in index, ${randomCardIndex} of ${allCards.length}`);
AppLogger.LogError("CardDropHelperMetadata/GetRandomCardByRarityUnclaimed", `Card not found in index, ${randomCardIndex} of ${allCards.length}`);
return undefined;
}
@ -61,7 +61,7 @@ export default class GetUnclaimedCardsHelper {
.find(x => x.cards.includes(card));
if (!series) {
AppLogger.LogWarn("CardDropHelperMetadata/GetRandomCardByRarityUnclaimed", `Series not found for card ${card.id}`);
AppLogger.LogError("CardDropHelperMetadata/GetRandomCardByRarityUnclaimed", `Series not found for card ${card.id}`);
return undefined;
}