External/card-drop
5
0
Fork 0
Code Issues 46 Pull requests 1 Projects 1 Releases 29 Packages Wiki Activity Actions

Create use effect command #419

Open
Vylpes wants to merge 26 commits from feature/380-use-effect into develop
pull from: feature/380-use-effect
merge into: External:develop
Conversation 0 Commits 26 Files changed 42 +4 -4
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit ff2980f3c0 - Show all commits

4
src/buttonEvents/Effects.ts
View file

@ -56,7 +56,7 @@ export default class Effects extends ButtonEvent {
const effectDetail = EffectDetails.get(id);
if (!effectDetail) {
await interaction.reply("Unable to find effect!");
await interaction.reply("Effect not found in system!");
Vylpes marked this conversation as resolved Outdated
Copilot commented 2024-12-31 17:11:50 +00:00
Outdated
Review
Copy link

The error message 'Unable to find effect!' is unclear. It should be 'Effect not found in the system!'.

The error message 'Unable to find effect!' is unclear. It should be 'Effect not found in the system!'.
return;
}
@ -114,7 +114,7 @@ export default class Effects extends ButtonEvent {
const effectDetail = EffectDetails.get(id);
if (!effectDetail) {
await interaction.reply("Unable to find effect!");
await interaction.reply("Effect not found in system!");
Vylpes marked this conversation as resolved Outdated
Copilot commented 2024-12-31 17:12:08 +00:00
Outdated
Review
Copy link

The error message 'Unable to find effect!' is unclear. It should be 'Effect not found in the system!'.

The error message 'Unable to find effect!' is unclear. It should be 'Effect not found in the system!'.
return;
}

4
tests/buttonEvents/Effects.test.ts
View file

@ -80,14 +80,14 @@ describe("Effects", () => {
interaction.customId = "effects use confirm invalid";
await effects.UseConfirm(interaction);
expect(interaction.reply).toHaveBeenCalledWith("Unable to find effect!");
expect(interaction.reply).toHaveBeenCalledWith("Effect not found in system!");
});
it("should reply with error message when effect detail is not found in UseCancel", async () => {
interaction.customId = "effects use cancel invalid";
await effects.UseCancel(interaction);
expect(interaction.reply).toHaveBeenCalledWith("Unable to find effect!");
expect(interaction.reply).toHaveBeenCalledWith("Effect not found in system!");
});
it("should update interaction with embed and row when effect is used successfully", async () => {