External/card-drop
5
0
Fork 0
Code Issues 46 Pull requests 1 Projects 1 Releases 29 Packages Wiki Activity Actions

Create use effect command #419

Open
Vylpes wants to merge 26 commits from feature/380-use-effect into develop
pull from: feature/380-use-effect
merge into: External:develop
Conversation 0 Commits 26 Files changed 42 +2
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 0092d91ee6 - Show all commits

2
src/helpers/CardDropHelperMetadata.ts
View file

@ -97,6 +97,8 @@ export default class CardDropHelperMetadata {
.filter(x => x.type == rarity) .filter(x => x.type == rarity)
.filter(x => !claimedCards.find(y => y.CardNumber == x.id)); .filter(x => !claimedCards.find(y => y.CardNumber == x.id));
if (!allCards) return undefined;
const randomCardIndex = Math.floor(Math.random() * allCards.length); const randomCardIndex = Math.floor(Math.random() * allCards.length);
Vylpes marked this conversation as resolved Outdated
Copilot commented 2025-01-03 14:36:19 +00:00
Outdated
Review
Copy link

The variable 'card' can be undefined if 'allCards' is empty. Add a check to ensure 'allCards' is not empty before accessing an element by index.

- const card = allCards[randomCardIndex];
+ if (allCards.length === 0) return undefined;
The variable 'card' can be undefined if 'allCards' is empty. Add a check to ensure 'allCards' is not empty before accessing an element by index. ```diff - const card = allCards[randomCardIndex]; + if (allCards.length === 0) return undefined; ```
const card = allCards[randomCardIndex]; const card = allCards[randomCardIndex];